1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-31 10:54:46 +03:00
Commit Graph

268 Commits

Author SHA1 Message Date
Michal Čihař
8d46edc4b6 Merge branch 'QA_4_6' 2016-08-24 12:03:37 +02:00
Michal Čihař
6879923acc Do not show warning about short blowfish_secret if none is set
With empty blowfish_secret user would always get both warnings...

Fixes #12485

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-24 12:03:22 +02:00
Michal Čihař
46b329c32b Merge branch 'QA_4_6' 2016-08-18 17:37:34 +02:00
Michal Čihař
6faa1fe46a Add rel="noopener noreferrer" to all external target="_blank" links
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-18 17:35:20 +02:00
Michal Čihař
52f23338a8 Merge branch 'master-security' 2016-08-17 08:50:51 +02:00
Isaac Bennetch
0f6b76b578 Merge remote-tracking branch 'security/QA_4_6-security' into QA_4_6 2016-08-16 16:34:37 -04:00
Michal Čihař
88b817a042 Merge branch 'QA_4_6' 2016-08-03 10:27:54 +02:00
Michal Čihař
91ff2a97e2 Open demo information in new tab
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-03 10:27:49 +02:00
Michal Čihař
12873604cb Merge branch 'master' into master-security 2016-08-02 09:16:12 +02:00
Michal Čihař
e7d4ef2fbc Merge branch 'QA_4_6' into QA_4_6-security 2016-08-02 09:16:03 +02:00
Michal Čihař
21a9bbea9f Merge branch 'QA_4_6' 2016-08-02 08:57:17 +02:00
Pavel Rochnyack
37c2886845 Improved indents, alignment and rtl in Original theme
* Fixed list items aligment in rtl view
* Fixed notices icon alignment in rtl and ltr views
* Fixed Footer.php getErrorMessages() to avoid <div id="pma_errors"><div id="pma_errors">....</div></div> nested blocks.
* Removed indentation by &nbsp;

Signed-off-by: Pavel Rochnyack <pavel2000@ngs.ru>
2016-08-01 03:08:48 +01:00
Michal Čihař
f5015c2ea3 Merge branch 'QA_4_6-security' into master-security 2016-07-26 16:31:21 +02:00
Michal Čihař
e67e69229a Remove option to show phpinfo() ($cfg['ShowPhpInfo'])
This is really more a PHP debugging feature than anything related to
phpMyAdmin. If user wants to debug, it's as simple a creating file with
one line of php code.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-23 11:31:46 +02:00
Michal Čihař
2adf1ca83e Merge branch 'QA_4_6-security' into master-security 2016-07-22 11:35:14 +02:00
Michal Čihař
f07fd90ee9 Document recommended length of 32 for blowfish_secret
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-22 10:14:02 +02:00
Michal Čihař
9348d0cb16 Separate adding HTML markup to message from others
We really want this to be explicit for easier review and hiding this in
second parameter of addParam doesn't make it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-16 13:41:35 +02:00
Isaac Bennetch
e6db8e18ee Fix some CodeSniffer warnings and errors
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2016-06-12 23:12:23 -04:00
Michal Čihař
95f2d15b4f Merge branch 'QA_4_6' 2016-05-17 10:12:04 +02:00
Michal Čihař
3771852471 Use https when linking to php.net
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-17 10:10:13 +02:00
Michal Čihař
ca5eb903b0 Make ThemeManager a singleton instead of storing it in the session
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-11 15:34:25 +02:00
Michal Čihař
5231649343 Merge commit 'cda4290749f10ed686bfb466b415e5e3a1c04fea' 2016-05-09 20:09:36 +02:00
Michal Čihař
b2f77691e9 Use https links where applicable
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-29 15:41:33 +02:00
Michal Čihař
bdb20d1499 Remove link to wiki
It's outdated and will be soon completely disabled.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-29 15:37:32 +02:00
Michal Čihař
59e56bd63a Pass link to demo server through url.php
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-29 15:36:54 +02:00
Michal Čihař
b311780d76 Separate methods for charset and collation dropdowns
They do not share much code in the end and this way the code is more
readable.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-11 13:04:41 +02:00
Michal Čihař
3e2029e750 Move MySQL charsets handling to the Charsets class
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-11 12:55:42 +02:00
Michal Čihař
cfc2f1cb05 Move charsets obtaining to the Charsets class
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-11 10:49:09 +02:00
Michal Čihař
cd4008b3d7 Move MySQL charset maps to separate class
This allows us to load it only when needed

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-11 10:33:40 +02:00
Durgesh
6650f7b07d Refactor text sanitization and javascript escaping, Issue #11989, #11988
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:45:19 +05:30
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Michal Čihař
5042b65398 Merge branch 'QA_4_5' into QA_4_6 2016-02-12 10:45:43 +01:00
Michal Čihař
4534a90b80 Silent warnings when checking for file existance
Another occurences of file_exists which can be limited by open_basedir.

Issue #11940

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-12 10:38:47 +01:00
Michal Čihař
2a9fb73f92 Remove PmaAbsoluteUri from redirects
This is no longer needed as per RFC 7231.

Issue #11412

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 14:32:14 +01:00
Michal Čihař
b1ac8170fd Show warning in version check and error reporting are not available
When curl is missing and allow_url_fopen is disabled, we can not access
remote files.

Fixes #11874

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-22 09:38:18 +01:00
Michal Čihař
28055b83e7 We no longer do cross site javascript request
Remove condition to disable version check on IE, it no loger makes sense
as we do the check server side.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-22 09:33:10 +01:00
Michal Čihař
47798a60e4 Show more used PHP extensions
This helps user to see what features are available.

Issue #11874

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-22 09:31:44 +01:00
Michal Čihař
908c44c027 Remove no longer used variables
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-12 14:51:08 +01:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Michal Čihař
98d88ef134 Remove unused pmaString variable
It was used in past when we didn't rely on mbstring.

Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-21 11:35:36 +01:00
Marc Delisle
06d22e636e Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-07 09:41:46 -05:00
Marc Delisle
357b1b4757 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-04 09:05:42 -05:00
Marc Delisle
9ee3931c09 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-03 10:43:10 -05:00
Michal Čihař
c7c2ff4ab6 issue #11708 Remove no password warning
The empty password has to be enabled by AllowNoPassword, so user should
know what he is doing. Showing this warning every time doesn't bring any
additional security.

Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-01 08:51:11 +01:00
Madhura Jayaratne
3839d2502f Link license.php
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-11-06 15:54:10 +11:00
Hugues Peccatte
ffc4422db7 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-19 20:33:21 +02:00
Hugues Peccatte
37bf6f2093 Update nodes load.
Fix template call.
Remove useless 'use'.
Fix node load.
Fix merge.
Attempt to fix transformation unit test.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-20 00:21:28 +02:00
Hugues Peccatte
a5d35d41b6 Revert PMA_String rename.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-14 22:39:03 +02:00
Hugues Peccatte
42c0ebac85 Merge branch 'master' into useNamespaces_master 2015-09-09 22:05:00 +02:00
Madhura Jayaratne
93bfdbe371 Remove more references to Drizzle
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-09-10 01:06:58 +10:00