webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-29 21:24:44 +03:00
Code Activity
124,341 Commits 12 Branches 481 Tags
d760df02ddbafa85ebba4149969aed5f2d6af02f
Commit Graph

1169 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
d760df02dd Move DBI getEvents method into the Events class 
DatabaseInterface::getEvents -> Database\Events::getDetails

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-10 12:48:44 -03:00
Maurício Meneghini Fauth
81192a142b Move DBI getRoutines method to the Routines class 
DatabaseInterface::getRoutines -> Database\Routines::getDetails

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-09 23:29:26 -03:00
Maurício Meneghini Fauth
d6b72de8aa Improve return type of Index::getPrimary method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 23:25:20 -03:00
Maurício Meneghini Fauth
9d2350d28c Extract dbi global variable from Index::loadIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 21:59:03 -03:00
Kamil Tekiela
f471e7f8e3 Clean up autocomplete controller 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-09-07 15:35:56 +01:00
Kamil Tekiela
f7f8722e1f Refactor insert edit (#17684) 
This is a major redesign of the code that handles these four actions: in-place edit(AJAX), edit of multiple rows, copying of rows, and insertion of new rows. The goal is to make the code easier to read and more understandable.

    I introduced a new DTO for better readability.
    Some of the methods were made private to the model
    The controller has access to two methods for getting the value for INSERT and for UPDATE
    Unfortunately, I have introduced method envy on EditField, but I do not want to move the functionality away from InsertEdit.php
    Unit tests have not improved in readability but I added helpful comments explaining what we are testing. There's probably a way to improve it too.

I will probably merge all commits once I decide it's ready for review.


Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-22 22:39:53 -03:00
Maurício Meneghini Fauth
a2ef27823e Merge pull request #17688 from kamil-tekiela/Fix-table-creation 
Fix table creation

Fixes #17544
 2022-08-18 22:54:53 -03:00
Kamil Tekiela
d14e334176 Update psalm-baseline.xml 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-17 21:20:50 +01:00
Kamil Tekiela
2e126d7f65 Fix table creation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-17 20:31:51 +01:00
Kamil Tekiela
0944221868 Extract moveBackToCallingScript 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-17 19:21:33 +01:00
Kamil Tekiela
6d91494935 Extract doTransformations 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-17 19:21:33 +01:00
Kamil Tekiela
1e70bba883 Fix bug not allowing insertion of set values 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-08 14:33:50 +01:00
Maurício Meneghini Fauth
75cf045fa3 Extract url.php entry point into a route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-06 15:02:49 -03:00
Maurício Meneghini Fauth
8645920f0d Extract normalization's partial dependencies action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 22:49:07 -03:00
Maurício Meneghini Fauth
28d53fe50b Extract normalization's create new column action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 21:38:55 -03:00
Maurício Meneghini Fauth
a37e5681c8 Extract normalization's get columns action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 20:48:48 -03:00
Maurício Meneghini Fauth
c550d41d1d Extract normalization's add new primary action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 16:45:30 -03:00
Maurício Meneghini Fauth
66970049cc Rename NormalizationController to Normalization\MainController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 15:57:05 -03:00
Maurício Meneghini Fauth
a5024edcc5 Extract normalization's move repeating group action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 15:31:41 -03:00
Maurício Meneghini Fauth
97c5c01a87 Extract normalization 3NF create new tables action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 14:43:13 -03:00
Maurício Meneghini Fauth
c9bccf3b3d Extract normalization 2NF create new tables action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 13:47:03 -03:00
Maurício Meneghini Fauth
b92e95d062 Extract normalization 3NF new tables action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 11:22:56 -03:00
Maurício Meneghini Fauth
efc04db52b Extract normalization 3NF step 1 action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-30 17:49:12 -03:00
Maurício Meneghini Fauth
dd25695569 Extract normalization 2NF new tables action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-30 00:36:58 -03:00
Maurício Meneghini Fauth
51db9db3dd Extract normalization 2NF step 1 action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-29 21:10:52 -03:00
Maurício Meneghini Fauth
bcb02c2e01 Extract normalization 1NF step 4 action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-29 20:11:56 -03:00
Maurício Meneghini Fauth
08297d96b8 Extract normalization 1NF step 3 action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-29 19:03:35 -03:00
Maurício Meneghini Fauth
6e8600f321 Extract normalization 1NF step 2 action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-28 22:52:28 -03:00
Maurício Meneghini Fauth
398bdae484 Extract normalization 1NF step 1 action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-28 18:33:34 -03:00
Maurício Meneghini Fauth
9c9ae5069e Extract HTML from Normalization::getHtmlForNormalizeTable method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-28 11:56:27 -03:00
Maurício Meneghini Fauth
3c618c22a9 Add ServerRequest parameter to all controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-28 01:00:08 -03:00
Maurício Meneghini Fauth
b0c4426a43 Add basic tests for Controllers\Table\Partition classes 
Adds better message for invalid partition name.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-27 15:29:02 -03:00
Maurício Meneghini Fauth
38564b5477 Check if db and table are strings in RecentFavoriteController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-22 17:16:09 -03:00
Maurício Meneghini Fauth
cba9b38a28 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-19 15:51:12 -03:00
Ankush Patil
987cb5043d fixed find replace regex issue if no matching result set found 
When find and replace searching used with regex, at the time of replace
empty CASE END condition was causing issue.

Fixes #17388
Closes #17641

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-19 15:28:43 -03:00
Maurício Meneghini Fauth
59b8f31a83 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-16 02:05:39 -03:00
William Desportes
6a69face6c Fix PHP 8.2: ${var} deprecated string interpolation syntax 
Ref: https://php.watch/versions/8.2/$%7Bvar%7D-string-interpolation-deprecated

Left over to patch:
- libraries/classes/Git.php#L397
- libraries/classes/Database/Qbe.php#L878
- libraries/classes/Database/Qbe.php#L879

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-07-13 11:14:20 +02:00
Maurício Meneghini Fauth
e4ea2308c0 Assign Messages global var to the window object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-02 11:23:07 -03:00
Maurício Meneghini Fauth
f5d738db59 Move input.sqlbutton event listener to sql.js file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-19 16:48:10 -03:00
Maurício Meneghini Fauth
7a6bd9eb57 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-15 21:14:18 -03:00
Maurício Meneghini Fauth
bf2add8312 Fix preview SQL modal not working inside Index modal 
- Fixes #17606

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-15 20:09:13 -03:00
Maurício Meneghini Fauth
905214ae0b Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-11 14:13:30 -03:00
Maurício Meneghini Fauth
bf084233ea Add ChangeLog entry for #17586 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-11 14:04:58 -03:00
Maurício Meneghini Fauth
bc61c2f8c3 Merge pull request #17587 from liviuconcioiu/statistics 
Fix #17586 Statistics not showing for empty databases

Fixes #17586
 2022-06-11 11:35:19 -03:00
Maurício Meneghini Fauth
e683f3aaa4 Merge pull request #17582 from kamil-tekiela/password_hash 
Fix errors in InsertEdit

Fixes #17121
Closes #17120
 2022-06-11 10:54:49 -03:00
Maurício Meneghini Fauth
fd5300e9e0 Merge pull request #17583 from kamil-tekiela/password_hash_5_2 
5.2 backport of #17582

Fixes #17121
Closes #17120
 2022-06-11 10:53:46 -03:00
Maurício Meneghini Fauth
a7a7490e15 Merge pull request #17579 from kamil-tekiela/ExportController 
Refactor getHtmlForDisplayedExportHeader
 2022-06-11 01:20:44 -03:00
Maurício Meneghini Fauth
3ac11ffa75 Introduce the ServerRequest object to ChangeController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-08 19:12:19 -03:00
Maurício Meneghini Fauth
eb3703882b Move Routing::getCurrentRoute to ServerRequest 
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-06 23:36:57 -03:00
Maurício Meneghini Fauth
e7487227e5 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-06 17:07:13 -03:00