webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-25 06:39:48 +03:00
Code Activity
123,574 Commits 12 Branches 481 Tags
d043ceedc638b140fce80098d78b453a9e600232
Commit Graph

280 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
217c6357e8 Fix FavoriteTableController error when missing db param 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-15 17:18:55 -03:00
Maurício Meneghini Fauth
5950693fb3 Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
f940693c75 Move Util::checkParameters method to the AbstractController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 22:59:33 -03:00
Maurício Meneghini Fauth
1438cb211e Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Kamil Tekiela
50303cd77e Fix numerical keys 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-02-12 20:11:04 +00:00
Maurício Meneghini Fauth
5a34a3bb04 Remove db and table properties from controllers 
Replaces them with their respective globals.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-02 14:48:43 -03:00
Maurício Meneghini Fauth
87f8ece01d Deprecate the db and table properties from controllers 
The database and table parameters should be got from the server request
or from the respective globals.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-28 20:51:03 -03:00
Maurício Meneghini Fauth
a8d514a350 Remove db and table globals from DbTableExists class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-28 16:43:48 -03:00
Kamil Tekiela
f5bb90ebb9 Move queryAsControlUser - Dbal refactoring pt.3 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:31:27 +00:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED 
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-01 01:46:01 +00:00
Maurício Meneghini Fauth
feca48cc76 Change return type of DatabaseInterface::getError method 
Now, it returns last error message or an empty string instead of false
if no errors occurred.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
d84af02945 Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c4e2582e56 Use TableName for RelationParameters tables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:57 -03:00
Maurício Meneghini Fauth
fa5c684f27 Replace the master/slave terminology 
Replaces master with primary and slave with replica.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-18 14:26:56 -03:00
Maurício Meneghini Fauth
c411121fd8 Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c4575fd48b Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Kamil Tekiela
945d887a10 Fix var annotation for Charset and Collation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-09 22:25:58 +00:00
Kamil Tekiela
253b08330d Make $subPart non-nullable and remove redundant ?? when it's not null 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-03 19:36:06 +00:00
Kamil Tekiela
f446e6da88 Remove unused variables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-03 15:12:56 +00:00
Maurício Meneghini Fauth
fbd5b0a67c Redesign the export/import pages to use Bootstrap components 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-25 13:37:47 -03:00
Maurício Meneghini Fauth
b2a51c4d84 Create the RelationParameters value object 
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
78104be8fb Remove print view mode 
- Removes the print.css file.
- Data ditionary now opens like other pages. Printing the page works
  like before.

Fixes #17169
Closes #17170

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-10-31 13:22:07 -03:00
Maurício Meneghini Fauth
3e0856c77b Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a Add bool return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
3531775b7c Add type declarations to the controllers contructors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-11 17:32:22 -03:00
Maurício Meneghini Fauth
e3554879ef Extract actions from controllers to new controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-07 21:19:43 -03:00
Maurício Meneghini Fauth
96adfe37f4 Extract actions from controllers to new ctrls 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-06 18:30:21 -03:00
Maurício Meneghini Fauth
5f4fd07483 Remove some assignments to the $_POST global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-03 15:49:39 -03:00
Maurício Meneghini Fauth
8f2f3eff40 Remove the Core::isValid method 
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
a2ed4dfe68 Make controllers callable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-30 13:16:29 -03:00
Maurício Meneghini Fauth
86798ec45e Refactor PhpMyAdmin\Plugins::getChoice method 
Extracts the getDefault method from the getChoice method and adds a
getName method to the Plugin interface.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-27 13:38:01 -03:00
Maurício Meneghini Fauth
84d175b282 Extract HTML from Plugins::getChoice method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-25 15:29:43 -03:00
Maurício Meneghini Fauth
7a4536d4d6 Remove PhpMyAdmin\Twig\PluginsExtension class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-25 11:00:21 -03:00
William Desportes
9373c8ec70 Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-22 14:51:35 +02:00
William Desportes
d281dcc0bd Fix #17026 - Handle possible invalid boolean values injected in SaveDir or UploadDir 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-22 12:59:54 +02:00
William Desportes
587536b766 Remove non used variables 
Running: composer run psalm -- --alter --issues=UnusedVariable
And removing the false positives I reported upstream

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-16 02:13:27 +02:00
Josep Sanz
de1c381f23 Add suport to the Mroonga engine: with this patch you can see the size 
of the Mroonga's tables

Apply an optimization suggested

In reality, I have applied 2 optimizations, the first consists in filter by the object type as @williamdes suggested to me and the second is because we don't need to store all data of each mroonga object, we only need the name of the object that is used to compare with the tables names, thanks @williamdes by the optimization idea

Signed-off-by: Josep Sanz <josep.sanz@saltos.org>
 2021-07-11 21:22:06 +02:00
Maurício Meneghini Fauth
e8c28d1883 Remove some globals from Config::enableBc method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-08 19:49:26 -03:00
Maurício Meneghini Fauth
9adaa912e1 Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
1129b68d29 Refactor PhpMyAdmin\Plugins::getPlugin method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-25 17:40:20 -03:00
Maurício Meneghini Fauth
1c084de30b Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
674bf8f97c Remove db, table and dbi globals from Tracking class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-26 16:40:05 -03:00
Maurício Meneghini Fauth
011915fe7b Add the redirect method to controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-07 12:23:26 -03:00
William Desportes
e1bf2b1ef9 Fix possible PHP errors on MultiTableQueryController 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-29 00:41:08 +02:00
William Desportes
a4bcd1cfc4 Move DBI getForeignKeyConstrains method to controller 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-29 00:19:02 +02:00
Maurício Meneghini Fauth
8d0c2a339c Move both operands of an assignment to the same line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-20 22:35:21 -03:00
Maurício Meneghini Fauth
b4effdd7f9 Rename Database\StructureController vars to use camel case 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-18 13:34:05 -03:00
William Desportes
38422023c5 Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-27 01:55:59 +01:00
William Desportes
702a9a444d Fix "Undefined index: target_db" reported on the error reporting server 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-27 01:10:46 +01:00