webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-25 06:39:48 +03:00
Code Activity
136,171 Commits 12 Branches 481 Tags
bcaf89c19fd583ddceded0ffc3c73ec6d2c019b5
Commit Graph

63 Commits

Author SHA1 Message Date
Kamil Tekiela
6302c979a9 Make controllers readonly 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-03-08 13:52:30 +00:00
Kamil Tekiela
0341f9dc23 Fix MaxDbList 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-02-19 21:29:30 +00:00
Maurício Meneghini Fauth
43ea6900cd Add Response return for ResponseRenderer::redirectToRoute() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-14 22:14:00 -03:00
Maurício Meneghini Fauth
a8b338cb40 Add the Route attribute to controllers classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-11 19:47:12 -03:00
Maurício Meneghini Fauth
e7765efd63 Make some comparisons stricter 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-06 15:44:31 -03:00
Kamil Tekiela
427479a0ef Non-nullable messageToShow 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-06-11 14:43:21 +01:00
Kamil Tekiela
0797f9c44b Rector: small improvements 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-06-11 14:43:20 +01:00
Kamil Tekiela
06057518b0 Separate strtoupper from getStorageEngine 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-20 18:39:56 +01:00
Maurício Meneghini Fauth
1a25a06d0d Replace Config::getInstance with DI in controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-01 21:51:43 -03:00
Maurício Meneghini Fauth
c52edb3e07 Move indexes classes to the Indexes namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-03-30 14:23:23 -03:00
Kamil Tekiela
065ee8524c Use getParsedBodyParamAsStringOrNull 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-02-04 23:45:22 +00:00
Maurício Meneghini Fauth
2b4aac5d0e Remove the message_to_show global variable 
Replaces it with Current::$messageToShow static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-01-10 17:23:30 -03:00
Maurício Meneghini Fauth
8f932a520e Remove the auto_increment global variable 
Replaces it with Operations::$autoIncrement static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-01-10 15:44:19 -03:00
Maurício Meneghini Fauth
138c5022fb Remove the single_table global variable 
Replaces it with Export::$singleTable static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-01-08 18:45:42 -03:00
Maurício Meneghini Fauth
ebea0aa748 Remove the reload global variable 
Replace it with ResponseRenderer::$reload static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-01-07 23:56:16 -03:00
Maurício Meneghini Fauth
03d9afc33f Replace message global with Current::$message prop 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-12-23 19:09:46 -03:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-22 18:34:53 +00:00
Kamil Tekiela
681c22b4be Split long line 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-14 02:19:04 +00:00
Kamil Tekiela
24fba67ccd Create ExportType enum 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-14 00:34:12 +00:00
Kamil Tekiela
dce24cca42 Make parameters a primitive type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-13 23:19:53 +00:00
Kamil Tekiela
ce016798f9 Remove all unnecessary $GLOBALS['errorUrl'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-12 23:05:34 +00:00
Maurício Meneghini Fauth
b68a82e38c Remove the ResponseRenderer::checkParameters() method 
Refactor it to use ResponseRenderer::missingParameterError() instead.

This provides better parameter handling for the controllers.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-12-09 17:48:27 -03:00
Maurício Meneghini Fauth
7d6b17a417 Replace sql_query global var with Current::$sqlQuery 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-12-09 13:51:22 -03:00
Kamil Tekiela
039481df30 Create UrlParams::$params 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-11-13 15:32:01 -03:00
Kamil Tekiela
cf6d5ed4b5 Use getParsedBodyParamAsString (#19333) 
* Use getParsedBodyParamAsString
* Remove unused stubs

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-10-29 12:07:39 -03:00
Kamil Tekiela
625dcf215a Split up getForeignKeysData from getForeigners 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-09-28 14:48:44 +01:00
Maurício Meneghini Fauth
d2060c56d5 Change InvocableController to always return a Response 
When 'null' is returned, ResponseRenderer::response() is called, so
call it early to always return a Response object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-05-22 15:22:56 -03:00
Kamil Tekiela
d265dbbd91 Replace Message constants with enum 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-05-14 16:30:45 +02:00
Kamil Tekiela
99c4d34db2 Create MessageType enum 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-05-14 16:30:45 +02:00
Maurício Meneghini Fauth
137283f909 Remove unused constructor params from controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-04-08 15:59:34 -03:00
Maurício Meneghini Fauth
c965d07f68 Remove Controllers\AbstractController abstract class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-04-08 15:59:33 -03:00
Maurício Meneghini Fauth
036e8ce95f Move AbstractController::render method to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-04-08 15:59:32 -03:00
Maurício Meneghini Fauth
7312c8eee5 Move AbstractController::checkParameters method to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-04-08 15:59:32 -03:00
Maurício Meneghini Fauth
c212478ac8 Move AbstractController::redirect method to ResponseRenderer class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-04-08 15:59:31 -03:00
Maurício Meneghini Fauth
235c61da17 Move addScriptFiles method to ResponseRenderer class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-04-08 15:59:30 -03:00
Maurício Meneghini Fauth
181f971bc9 Create InvocableController interface 
This creates the contract for the controllers.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-04-03 17:03:00 -03:00
Kamil Tekiela
2f3c4d3830 Refactor Operations::getWarningMessagesArray 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-03-23 14:39:05 +01:00
Kamil Tekiela
8e4443b17b Applying suggestions from static analysis tools (#19013) 
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-27 12:29:02 -03:00
Maurício Meneghini Fauth
20364c92fc Rename CheckUserPrivileges class to UserPrivilegesFactory 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-02-10 19:26:52 -03:00
Maurício Meneghini Fauth
8ee44a377e Refactor UserPrivileges to use instance instead of static props 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-02-09 15:49:00 -03:00
Kamil Tekiela
aa6ce1d263 Optimize CollationController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-08 23:28:53 +01:00
Kamil Tekiela
822ebbfe59 Remove unnecessary parentheses 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-12 15:26:31 +01:00
Kamil Tekiela
349ae8de27 Replace mb_strstr 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-11 23:43:58 +01:00
Maurício Meneghini Fauth
4fefea40c7 Extract privileges globals to static props of UserPrivileges class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-01-05 17:50:13 -03:00
Kamil Tekiela
62fac42bd8 Improve code quality 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-27 15:08:09 +01:00
Maurício Meneghini Fauth
98ee8f7158 Merge pull request #18862 from MauricioFauth/server-global 
Replace server global with Current::$server
 2023-12-24 17:48:28 -03:00
Maurício Meneghini Fauth
1129750eee Replace server global with Current::$server 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-24 02:08:50 -03:00
Kamil Tekiela
cfe88447bc Remove unnecessary force reads of table status 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-20 21:07:03 +01:00
Kamil Tekiela
e7cc859d7d Instead of rereading, clear cache 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-20 21:07:03 +01:00
Maurício Meneghini Fauth
ef6c30c865 Replace table global var with static class property 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-17 15:51:29 -03:00