1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-29 21:24:44 +03:00
Commit Graph

2500 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
30b5fc46d2 Extract HTML from table operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-24 20:00:13 -03:00
William Desportes
d042b6e2bb Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 23:25:07 +01:00
William Desportes
3db8949ad3 Fix #15200 - server-side HTTPS detection misses support for Forwarded HTTP Extension (RFC 7239)
Fixes: #15200
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 22:56:55 +01:00
Maurício Meneghini Fauth
aa0f8a6efe Extract HTML from the database operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 22:56:29 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
42166cac37 Remove use statements within the same namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 19:47:56 -03:00
Maurício Meneghini Fauth
585fdaea5a Fix PHP doc spacing and order
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 18:07:37 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
dcf87edbd1 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 03:18:59 -03:00
Maurício Meneghini Fauth
f76499af7f Use Throwable instead of Exception
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 01:16:40 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
63dbcd01d9 Remove or ignore side effects in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 20:22:37 -03:00
William Desportes
d292855d69 Merge branch 'QA_5_0'
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 14:45:43 +01:00
William Desportes
187194b7e6 Merge #15805 - Fix #15802 - removed SET AUTOCOMMIT=0 from export
Fixes: #15802
Pull-request: #15805
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 14:10:35 +01:00
Maurício Meneghini Fauth
59ce2dbd67 Fix MonitorControllerTest
Fixes Server\Status\MonitorControllerTest when runned in isolation.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:46:27 -03:00
Maurício Meneghini Fauth
2e2c20ac31 Merge pull request #15759 from mauriciofauth/replication-include
Remove replication.inc.php file
2020-01-07 19:16:19 -03:00
William Desportes
3311c089c4 Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-07 21:25:25 +01:00
William Desportes
af100abddf Add more tests for testCookieDecrypt
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-07 19:07:27 +01:00
Maurício Meneghini Fauth
08afb43653 Remove replication.inc.php file
Extracts the replication.inc.php code to the ReplicationInfo class and
removes the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 14:31:46 -03:00
bepsvpt
fd553a45d5 Update and revert "Remove a test that can not be predictible"
This reverts commit a6155da6a9.

Co-authored-by: bepsvpt <og7lsrszah6y3lz@infinitefa.email>

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-07 21:02:04 +08:00
Maurício Meneghini Fauth
7837ab81f2 Remove the table sql entry point file
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
d190c82f1e Remove the table change entry point file
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
42468cb033 Remove the database sql entry point file
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
William Desportes
106ec8dee2 Merge branch 'QA_5_0'
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-07 01:36:03 +01:00
William Desportes
a6155da6a9 Remove a test that can not be predictible
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-07 00:28:35 +01:00
William Desportes
c1c8e09586 Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-06 23:45:16 +01:00
William Desportes
a5ec07f0e9 Merge #15753 - fix #14875 shp import tests where failing
Pull-request: #15753
Fixes: #14875
Closes: #15753
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-06 23:40:56 +01:00
bepsvpt
879b7fe681 fix #14875 - fix shp filename sanitization and update test
Co-authored-by: bepsvpt <og7lsrszah6y3lz@infinitefa.email>

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-06 23:00:55 +01:00
William Desportes
21c2bcdbb3 Add Unit tests
Closes #15752

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-06 21:45:49 +01:00
Maurício Meneghini Fauth
4fcc1466d8 Refactor Table\StructureController controller
Extracts the table structure entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-04 15:02:28 -03:00
William Desportes
9b15f10bc7 Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-30 18:52:02 +01:00
William Desportes
e1b1f155ef Add a test for pull-request #15666
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-30 18:44:29 +01:00
Yunhao Tian
56be819ee4 Renders absolutely nothing when header is not enabled.
When downloading blob data from database, the header template will be rendered as `\n` which adds an extra 0x0A at the beginning of the blob data. This fixes the problem.

Signed-off-by: Yunhao Tian <18373444@buaa.edu.cn>
2019-12-30 18:42:05 +01:00
William Desportes
fa01cea3f2 Add phpdoc blocks for phpstan
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 15:28:18 +01:00
Maurício Meneghini Fauth
e36f5a1938 Refactor Table\SearchController
Moves the table select entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-28 22:18:29 -03:00
Maurício Meneghini Fauth
98424ec065 Extract class from Table\SearchController
Extracts the buildSqlQuery method from
Controllers\Table\SearchController class to the new Table\Search class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-27 22:01:28 -03:00
Maurício Meneghini Fauth
ee8951ea74 Create Table\FindReplaceController controller
Moves the table find-replace entry point logic to the
FindReplaceController, removes the entry point file and extracts the
find-replace logic from the Table\SearchController class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-27 17:54:19 -03:00
Maurício Meneghini Fauth
3f522e8ae2 Fix some tests when running them in isolation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 21:16:30 -03:00
Maurício Meneghini Fauth
62eecc8f5d Fix Server\Status\MonitorControllerTest tests
Adds missing $response->setAjax(true) calls.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 14:10:08 -03:00
Maurício Meneghini Fauth
693bf67b1c Refactor Database\CentralColumnsController class
Moves the central columns entry point logic to the controller and
removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 12:51:35 -03:00
Maurício Meneghini Fauth
ab9d94b2b3 Refactor Table\IndexesController controller
Moves the indexes entry point logic to the controller and removes the
entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 12:28:30 -03:00
Maurício Meneghini Fauth
af1c859a03 Refactor Table\RelationController controller
Moves the table relation entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-25 01:28:38 -03:00
William Desportes
6468a96a79 Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-24 21:31:10 +01:00