Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824
Use short versions of scalar types in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
5e0f539d2f
Fix invalid @var php doc annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-21 13:19:08 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67
Remove useless comments in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f
Remove useless PHP docs for functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
dcf87edbd1
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-20 03:18:59 -03:00
Maurício Meneghini Fauth
8ec4209002
Fix some coding standard issues
...
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e
Add coding standard rules for whitespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-19 22:29:54 -03:00
William Desportes
249ee4dbd2
Improve JS and phpdoc by removing useless spaces
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-01-16 18:39:42 +01:00
William Desportes
13c3a18df7
Use more strict code after #15796
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-01-16 18:16:41 +01:00
Signed-off-by: Tabraiz Malik
a3fec80dfe
User Groups table to twig
...
Signed-off-by: Tabraiz Malik <tabraizmalik96@gmail.com >
2020-01-16 14:04:34 +01:00
William Desportes
d1e38545f3
Fix #15761 - Fix uncaught TypeError when using $cfg['ServerDefault'] = 0; on 5.1
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-01-15 13:57:38 +01:00
Maurício Meneghini Fauth
c5481acebf
Merge branch 'QA_5_0'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-14 18:54:02 -03:00
William Desportes
aa95fff919
Fix #15776 - privileges page return http 500
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-01-12 22:18:44 +01:00
William Desportes
6e6c3e0363
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-01-10 12:45:47 +01:00
Yash Bothra
7c862e5c30
#15767 fixed by changing === to !==
...
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com >
2020-01-10 15:34:41 +05:30
Isaac Bennetch
a89f3fe750
Fix merge conflicts
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com >
2020-01-08 15:18:01 -05:00
Isaac Bennetch
dc1e81e6b2
Fix merge conflicts from QA_4_9 and prepare for 5.0.1
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com >
2020-01-07 20:56:25 -05:00
Maurício Meneghini Fauth
08afb43653
Remove replication.inc.php file
...
Extracts the replication.inc.php code to the ReplicationInfo class and
removes the file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-01-07 14:31:46 -03:00
William Desportes
c86acbf3ed
Fix sql injection in user exists request
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-01-01 13:55:06 +01:00
William Desportes
51f292beab
Improve some params and return types marked as mixed
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2019-12-29 14:33:49 +01:00
Maurício Meneghini Fauth
b1328c7ad6
Create Server\UserGroupsController controller
...
Moves the user groups entry point logic to the controller and removes
the entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-12-22 11:54:34 -03:00
Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e
Remove unused use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f6a17433a2
Use null coalesce operator when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
12db01bfc3
Merge pull request #15604 from mauriciofauth/double-quote-usage
...
Defines rules for double quote usage
2019-12-03 13:04:28 -03:00
Maurício Meneghini Fauth
acf37d7921
Move user password entry point to a controller
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-12-02 17:45:23 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b
Split Util class regarding the responsabilities ( #15567 )
...
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.
There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.
* Split Util class regarding the responsabilities
* Split the buttonOrImage function
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com >
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
ed6d079f25
Move server status entry point logic to routes file
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-10-26 14:54:26 -03:00
Maurício Meneghini Fauth
6dd961c8f3
Refactor server engines entry point
...
Moves server engines entry point logic to the routes files and moves the
request parameters to the route parameter.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-10-26 12:55:54 -03:00
Maurício Meneghini Fauth
441f8daa1a
Use gender-neutral pronouns
...
Replaces gender-specific pronouns with gender-neutral pronouns.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-10-18 09:13:08 -03:00
Maurício Meneghini Fauth
13e1362f26
Add initial suport for prepared statements
...
Creates the DbiExtension::prepare method.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-10-06 11:46:40 -03:00
Maurício Meneghini Fauth
d7bc90fa2c
Extract HTML from db and table links line
...
Server\Privileges::getLinkToDbAndTable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-10-05 20:07:38 -03:00
Maurício Meneghini Fauth
cc44bd9e67
Move change login info to user properties template
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-10-05 16:37:08 -03:00
Maurício Meneghini Fauth
dff5619d53
Move radio fields HTML to the template
...
... in Server\Privileges::getChangeLoginInformationHtmlForm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-10-05 13:48:00 -03:00
Maurício Meneghini Fauth
462b139503
Extract HTML from change user login info form
...
Server\Privileges::getChangeLoginInformationHtmlForm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-10-04 21:44:20 -03:00
Maurício Meneghini Fauth
5cc67095fe
Extract HTML from new user ajax call
...
Server\Privileges::getExtraDataForAjaxBehavior
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-10-03 22:25:40 -03:00
Maurício Meneghini Fauth
b075f07b02
Extract method from getAllPrivileges
...
Extracts specific privilege logic to the getSpecificPrivilege method.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-10-02 10:17:20 -03:00
Maurício Meneghini Fauth
672aee2d8a
Create Database\PrivilegesController
...
Extracts Server\Privileges::getHtmlForSpecificDbPrivileges method to a
controller.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-09-29 21:09:24 -03:00
Maurício Meneghini Fauth
600079f0f0
Create Table\PrivilegesController
...
Extract Server\Privileges::getHtmlForSpecificTablePrivileges to a
controller.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-09-29 16:32:07 -03:00
Maurício Meneghini Fauth
9b36c0116d
Extract method to get all db and table privileges
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-09-29 00:38:48 -03:00
Maurício Meneghini Fauth
2330212d0d
Refactor and extract HTML from db privileges page
...
Server\Privileges::getHtmlForSpecificDbPrivileges
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-09-28 21:04:24 -03:00
Maurício Meneghini Fauth
860290eef4
Refactor and Extract HTML from table privs page
...
Server\Privileges::getHtmlForSpecificTablePrivileges
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-09-28 20:25:01 -03:00
Maurício Meneghini Fauth
b24c2fb7f8
Refactor db and table privileges code
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-09-25 16:15:17 -03:00
Maurício Meneghini Fauth
03b0c0c336
Extract HTML from routine based privileges
...
Server\Privileges::getHtmlTableBodyForSpecificDbRoutinePrivs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2019-09-22 11:38:54 -03:00