1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-29 21:24:44 +03:00
Commit Graph

454 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
1835ebb4fc Replace mb_strpos !== false with str_contains
See: https://wiki.php.net/rfc/str_contains#case-insensitivity_and_multibyte_strings

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-10 13:43:40 -03:00
Maurício Meneghini Fauth
6ae07c96fb Replace strpos !== false with str_contains
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
e8c28d1883 Remove some globals from Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-08 19:49:26 -03:00
Maurício Meneghini Fauth
8e4d6229a9 Fix some errors found by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 00:37:27 -03:00
Maurício Meneghini Fauth
069d8e13db Fix error found by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-05 15:23:46 -03:00
Maurício Meneghini Fauth
9adaa912e1 Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
cc0cc79253 Accept only string for Response::addHTML method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-29 18:04:18 -03:00
William Desportes
6996e8dd28 Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 19:01:02 +02:00
William Desportes
535b374163 Fix "Undefined index: clause_is_unique" on replace value in cell
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 18:27:38 +02:00
Maurício Meneghini Fauth
21431578db Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-24 18:03:14 -03:00
William Desportes
300e835edb Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-16 01:10:11 +02:00
William Desportes
f09ead5e07 Fix code using relative path
if (chdir('/tmp') === false) {
    die('Could not change dir');
}

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-15 22:24:30 +02:00
Maurício Meneghini Fauth
1c084de30b Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
eff631ac1b Extract HTML from the InsertEdit::getActionsPanel method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 12:06:17 -03:00
Maurício Meneghini Fauth
674bf8f97c Remove db, table and dbi globals from Tracking class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-26 16:40:05 -03:00
Maurício Meneghini Fauth
5faf95016f Use DatabaseName VO for db names in Table\Partition
- Adds DatabaseName support for DatabaseInterface::selectDb method

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-21 21:30:37 -03:00
Maurício Meneghini Fauth
4d09e19216 Add DatabaseName value object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-21 16:17:28 -03:00
Maurício Meneghini Fauth
4dec56d883 Remove get_start_and_number_of_rows_panel() Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-17 17:56:34 -03:00
Maurício Meneghini Fauth
467ef3cd63 Extract the drop column action to a new controller
Extracts the drop action method from Table\StructureController to the
Table\DropColumnController class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-07 12:42:40 -03:00
Maurício Meneghini Fauth
011915fe7b Add the redirect method to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-07 12:23:26 -03:00
Maurício Meneghini Fauth
5b2957bdc1 Add a redirection after dropping a column
Instead of loading the page in the same action, redirect to the table
structure page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-07 11:24:12 -03:00
Maurício Meneghini Fauth
5f1084ff78 Extract new controller for drop column confirmation
Extracts the Table\StructureController::dropConfirm action to the
Table\DropColumnConfirmationController controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-06 14:40:10 -03:00
William Desportes
db01d6a9da Remove some else conditions by using early exits or moving code
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 01:18:39 +02:00
William Desportes
d82e85f852 Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-23 18:46:05 +02:00
William Desportes
45aeee579a Fix #14773 - export raw query is not working
Ref: #15064 (issue to track the export raw query feature)
Yes, this issue was closed with #15064 but I will close it anyway because it made sense as the feature was broken once more
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-23 17:46:26 +02:00
William Desportes
e0c1dea460 Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-23 03:16:29 +02:00
liviuconcioiu
6dc79009f7 Fix #16810 - SQL query shown twice
Fix SQL query shown twice on PRIMARY, UNIQUE, INDEX, SPATIAL, FULLTEXT, add to central columns, remove from central columns

Signed-off-by: Liviu Concioiu <liviu.concioiu@gmail.com>
2021-04-23 03:05:46 +02:00
Maurício Meneghini Fauth
8d0c2a339c Move both operands of an assignment to the same line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
William Desportes
8fbb01a684 Merge branch 'origin/QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 21:51:45 +02:00
William Desportes
ec4df90ab6 Merge #16811 - Fix #16810 - Fix SQL query shown twice on drop
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 19:19:30 +02:00
William Desportes
ba35901594 Merge branch 'origin/QA_5_1' into master
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-17 00:53:14 +02:00
William Desportes
deac7cffde Fix not working export to PNG, SVG, PDF on GIS visialization
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-17 00:28:38 +02:00
William Desportes
856145297f Merge branch 'origin/QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-13 17:46:06 +02:00
William Desportes
b78f8a094c Fix #16790 - Undefined index field_name
Unable to reproduce, adding a safety will make the code run properly.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-12 22:31:37 +02:00
Saksham Gupta
db5fc3fd7f Fix #16810 Fix SQL query shown twice on drop
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-04-12 23:20:48 +05:30
William Desportes
9f0fc40cdb Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-02 13:40:28 +02:00
William Desportes
700108ba90 Add missing stickfill script on zoom search
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-01 18:31:53 +02:00
Maurício Meneghini Fauth
bbb117b30b Extract the HTML from InsertEdit::getFunctionColumn
Removes positive tabindex from function and null cells.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-28 17:17:19 -03:00
Maurício Meneghini Fauth
44bdd1d390 Rename $url_params global to $urlParams
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-24 22:48:14 -03:00
Maurício Meneghini Fauth
91bd0df2e5 Rename $err_url global to $errorUrl
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-24 19:39:28 -03:00
William Desportes
993a6aa8a0 Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 01:13:58 +01:00
Maurício Meneghini Fauth
035e29a80b Extract GIS related methods from Util class
Creates the PhpMyAdmin\Utils\Gis class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-22 15:03:39 -03:00
Saksham Gupta
04d72a8291 Fix #16703 No SQL option on Export of rows from a table
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add null fallback

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Update yarn.lock
2021-03-22 22:34:06 +05:30
Maurício Meneghini Fauth
caa3337411 Extract FK related methods from Util class
Creates the PhpMyAdmin\Utils\ForeignKey class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-21 15:25:45 -03:00
William Desportes
0b440f2652 Ref #16651 - Fix and improve the chart checking for int columns
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-15 01:30:35 +01:00
William Desportes
c71c11e787 Remove an exit by moving out the preview SQL code on table create add field
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-11 21:09:46 +01:00
William Desportes
7aabad9b7a Move queries from Operations class to the Query\Generator class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-06 02:11:25 +01:00
Maurício Meneghini Fauth
d83abf63e7 Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
c5155ecae9 Refactor field flags to use an object an not strpos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-24 23:56:33 +01:00