1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-25 06:39:48 +03:00
Commit Graph

158 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
a57102412c Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-26 10:42:45 -03:00
Maurício Meneghini Fauth
feda222da9 Fix failing tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-26 10:02:26 -03:00
Maurício Meneghini Fauth
67e96cf40c Get default config values from Config\Settings classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
3e0856c77b Remove useless string concatenations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
William Desportes
587536b766 Remove non used variables
Running: composer run psalm -- --alter --issues=UnusedVariable
And removing the false positives I reported upstream

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-16 02:13:27 +02:00
Maurício Meneghini Fauth
355f6d9d20 Remove PhpMyAdmin\Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
e8c28d1883 Remove some globals from Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-08 19:49:26 -03:00
Maurício Meneghini Fauth
21431578db Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-24 18:03:14 -03:00
Maurício Meneghini Fauth
9920b877f9 Fix some tests with PHP 8.1
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-11 18:14:40 -03:00
Maurício Meneghini Fauth
f3b79d83c0 Add PHPUnit's Covers annotation on test classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
b4f3a2c8aa Fix some failing PHPUnit tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-02 14:53:17 -03:00
William Desportes
bca8284a37 Allow testGetThemeUniqueValue on 32-bit systems
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-25 01:11:11 +02:00
William Desportes
6699fb1923 Fix 32-bit issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-24 22:03:41 +02:00
William Desportes
3eb0c770fc Replace assertFileDoesNotExist for older phpunit versions
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-20 22:26:01 +02:00
William Desportes
f8ebd7ad7b Add test cases for config file loading and removing keys having a '/' in the name
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-20 21:50:33 +02:00
fliespl
ef6fb5e3bc drop nocache & server query string param from theme.css stylesheet
Signed-off-by: Arkadiusz Rzadkowolski <a.rzadkowolski@gmail.com>
2021-03-20 22:48:07 +01:00
Maurício Meneghini Fauth
33d711215d Remove the PMA_VERSION constant
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5 Rename the PMA_Config global variable to config
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
2c2127b369 Rename PMA_Theme global variable to theme
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-07 15:15:27 -03:00
William Desportes
b5263d44c8 Replace PMA_MAJOR_VERSION by Version::SERIES
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-05 21:22:42 +01:00
Maurício Meneghini Fauth
d83abf63e7 Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
William Desportes
0d97b16d16 Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-13 14:13:03 +02:00
William Desportes
1fcb62e563 Flag 32 bit incompatible tests
Group:  32bit-incompatible

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-11 19:05:14 +02:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
William Desportes
e9b1a560f9 Move Git tests to GitTest
Ref: f993c46e76
Ref: 585ae508ebf32be96550e50dfd0e14b0521524e0585ae508ebf32be96550e50dfd0e14b0521524e0585ae508ebf32be96550e50dfd0e14b0521524e0

This is a double cherry-pick merged and fixed for QA_5_0

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-29 11:27:57 +02:00
Maurício Meneghini Fauth
2358b9c4f9 Fix missing property type hints
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 21:42:22 -03:00
William Desportes
0340f66740 Fix some tests having wrong typehints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 23:55:49 +02:00
William Desportes
a80153a633 Add typehints using phpcbf on test/*
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 22:52:42 +02:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
William Desportes
802797c176 Move getConnectionParams to Config class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 16:01:38 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
William Desportes
a300a25319 Replace assertEquals({false,true} by assert{false,true}
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
William Desportes
49a6d6e8d0 Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:45:50 +02:00
William Desportes
ae575ffb14 Fix running tests in --process-isolation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 16:21:20 +02:00
William Desportes
8f7d3d1fa7 Fix test cases after backupGlobals = false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805 Call parent's setUp and tearDown
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
0138cb471f Some minor code improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-17 22:29:57 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
585ae508eb Move out of Config Class all Git methods
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 15:18:45 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
d042b6e2bb Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 23:25:07 +01:00
William Desportes
3db8949ad3 Fix #15200 - server-side HTTPS detection misses support for Forwarded HTTP Extension (RFC 7239)
Fixes: #15200
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 22:56:55 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00