1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-29 21:24:44 +03:00
Commit Graph

261 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
c8c2e9d793 Refactor tbl_columns_definition_form.inc.php
Extracts the tbl_columns_definition_form.inc.php logic to the
PhpMyAdmin\Table\ColumnsDefinition::displayForm static method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-17 02:55:20 -03:00
William Desportes
01cd7dc33b Some code improvements suggested by Scrutinizer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 22:23:16 +01:00
William Desportes
517222ff59 Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-13 00:07:11 +01:00
William Desportes
0b2937dd6a Fix #15781 - Illegal string offset error on structure page of 'information_schema'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-12 23:11:41 +01:00
Maurício Meneghini Fauth
30b5fc46d2 Extract HTML from table operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-24 20:00:13 -03:00
William Desportes
b736f0a79f Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 22:00:16 +01:00
William Desportes
36e4cf8f88 Fix after pull-request #15846 - add support for unsigned ints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 21:24:53 +01:00
William Desportes
afce79c4bd Merge #15846 - Fix #13326 - added Integer Validations on Search page
Fixes: #13326
Pull-request: #15846
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 21:11:54 +01:00
Manthan Surkar
e92e51d42d Added: Integer Validations on Search page
Signed-off-by: Manthan Surkar <manthan.surkar@gmail.com>
2020-01-25 01:21:19 +05:30
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
dcf87edbd1 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 03:18:59 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
3c22f5e7b2 Add conding standard rule for useless method overrides
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:56:23 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
William Desportes
ae0577ab1e Merge #15820 - Fix #15797 - Relation view broken
Fixes: #15797
Pull-request: #15820
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 15:43:59 +01:00
Jayati Shrivastava
5a03410cfa fixes url.
fixes #15797

Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-19 20:06:03 +05:30
William Desportes
fd036d7f4a Merge #15808 - Fix #15312 - added LOCK=NONE to ALGORITHM=INPLACE
Fixes: #15312
Pull-request: #15808
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 13:53:25 +01:00
Maurício Meneghini Fauth
77d5b1d8d8 Remove extract functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-17 19:44:00 -03:00
Kartik Kathuria
9054d1f673 Added LOCK=NONE
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2020-01-17 20:42:09 +05:30
Kartik Kathuria
a439082dba Change ALTER ONLINE to ALGORITHM=INPLACE at required position
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2020-01-17 13:36:06 +05:30
Maurício Meneghini Fauth
c5481acebf Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-14 18:54:02 -03:00
Jayati Shrivastava
f14d675308 revert change introduced by pr #15718 and fix #15718
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-12 18:46:23 +01:00
Maurício Meneghini Fauth
d0f28cef30 Refactor table pages common code
Extracts tbl_common.inc.php code to the Common::table() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
385e7f86c0 Refactor database pages common code
Extracts db_common.inc.php code to the Common::database() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
a1bcb9f0f3 Refactor server pages common code
Extracts server_common.inc.php code to the Common::server() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
96ee3b8ab0 Remove the table structure entry point file
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
7837ab81f2 Remove the table sql entry point file
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
634c9f38e9 Remove the table replace entry point file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
4ffb6712ff Remove the table export entry point file
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
d190c82f1e Remove the table change entry point file
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
42468cb033 Remove the database sql entry point file
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
cbce3a66e3 Remove the sql entry point file
Directly calls the controller instead of including the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
William Desportes
77ffaa9d4c Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-07 00:15:26 +01:00
Maurício Meneghini Fauth
4fcc1466d8 Refactor Table\StructureController controller
Extracts the table structure entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-04 15:02:28 -03:00
Maurício Meneghini Fauth
363707890b Refactor Table\SqlController controller
Moves the table sql entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-04 13:50:02 -03:00
Maurício Meneghini Fauth
fc9fcd1550 Create Table\ReplaceController controller
Extracts the table replace entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-04 13:27:48 -03:00
Maurício Meneghini Fauth
a6e6555b73 Create Table\ExportController controller
Extracts the table export entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-04 12:43:46 -03:00
Maurício Meneghini Fauth
f4eb233b59 Create Table\ChangeController controller
Extracts the table change entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-03 17:21:08 -03:00
William Desportes
c14500f323 Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-02 15:50:55 +01:00
Jayati Shrivastava
f428e4eeb7 Fixes #15717 - Warning popup not dissapearing
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-02 15:44:37 +01:00
Maurício Meneghini Fauth
5ad33769b9 Create Table\ImportController controller
Moves the table import entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-29 17:23:14 -03:00
Maurício Meneghini Fauth
e36f5a1938 Refactor Table\SearchController
Moves the table select entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-28 22:18:29 -03:00
Maurício Meneghini Fauth
36730b33bd Create Table\ZoomSearchController controller
Moves the table zoom search entry point to the ZoomSearchController,
removes the entry point file and extracts the zoom search logic from the
SearchController class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-28 00:18:26 -03:00