1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-29 21:24:44 +03:00
Commit Graph

372 Commits

Author SHA1 Message Date
Michal Čihař
f281a217b1 Fix test expectation
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-16 12:18:37 +02:00
Michal Čihař
6a645a3e89 Revert "Fix alignment of action and fixed tests #12167"
This reverts commit 9b56acacab.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-03 14:02:49 +02:00
Maurício Meneghini Fauth
1c111bf772 Merge pull request #13702 from ankitjain28may/ankitjain28may
Fix alignment of action #12167 

Fix #12167
2017-09-29 21:38:45 -03:00
Michal Čihař
3e7281e620 Include additional space in input
It seems that last char is sometimes lost and space is harmless

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-28 11:10:36 +02:00
ankitjain28may
9b56acacab Fix alignment of action and fixed tests #12167
Signed-off-by: Ankit Jain <ankitjain28may77@gmail.com>
2017-09-26 01:37:02 +05:30
Michal Čihař
28345a5cd3 Skip QBE tests early
There is no need to bother with connecting to BrowserStack here.

Issue #13621

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 16:24:14 +02:00
Michal Čihař
f1326358d2 Add separate wait for message to disappear
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:35:33 +02:00
Michal Čihař
877d620c87 Add some missing AJAX waits in events/procedures/triggers
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
e9dece41a9 Simplify waitAjax
Wait only based on javascript flag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
3b19cbef9e Remove not needed waitForElement
The page is already loaded here, so there is no reason to wait.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
580cb38562 We need to scroll relatively as getBoundingClientRect returns offset
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
2f13f070cb Ensure widgets are in the view
Scroll based on actuall widgets we target, not by arbitrary values.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
fa2457cf3d Simplify entering form values
Use value() instead of click() and keys().

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
11ff884f6a Remove sleeps from export tests
Those really should not be necessary or we should add some dynamic waits.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
2abb2db01d Remove sleep after scrollToBottom, should not be necessary
The javascript is executed synchronously, so there should be no delay.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
5c40939e74 Remove some no longer needed waits and sleeps
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
c3f8315858 Fixed waiting for event/procedure/trigger drop
The nothing2display element is always present, sometimes it is just
hidden. Wait for AJAX completion instead.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
037dde0e42 Share code for waiting for CodeMirror
It takes some time to initialize, so we should wait for it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
bbf84bd5f7 Remove strange wait loops
Those were most likely caused by wrong waiting on AJAX page load.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
c674ab8791 Try getting element directly in waitForElement
This can avoid 3 round trips to Selenium server in most situations, so
it can help performance.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
eae223215a Run Chrome tests on Windows
It seems to perform way better with webdriver than OS X.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
eabdf845c3 Fix waiting for AJAX popup disappear in Selenium tests
Waiting for ajax_message_num_1 works only on first AJAX request and
we're doing more of them. This should remove need for many consequent
sleeps as we were actually not properly waiting for element.

Also it's better to wrap this logic in separate method as it is used in
many places in the code.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
eefc2cc47e Skip broken test
See https://github.com/phpmyadmin/phpmyadmin/issues/13621

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-05 14:45:29 +02:00
Deven Bansod
32c19d9710 Add sleep to allow the tables to resize and prevent possible errors
The elements are not properly aligned and hence the click does not go through

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-23 16:12:33 +05:30
Deven Bansod
b72b5ab5f1 Add navigateDatabase method to prevent navigation errors
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-22 16:42:37 +05:30
Deven Bansod
11bc4c6252 Replace usleep with sleep calls
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-22 16:42:37 +05:30
Deven Bansod
8c32018335 Refactor methods in selenium tests
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-22 16:42:37 +05:30
Michal Čihař
dac19fbe7e Merge pull request #13594 from devenbansod/fix_selenium_2
Fix random selenium failure tests
2017-08-21 11:01:05 +02:00
Deven Bansod
94d8d897ce Clear input fields to avoid duplicate texts
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-20 13:49:37 +05:30
Deven Bansod
a5d6c06812 Fix another possible failure point in DbEvents - testAddEvent
See: https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/266409700 for example

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-20 13:01:17 +05:30
Deven Bansod
26d80bd975 Fix DbEvents test
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-18 16:31:27 +05:30
Deven Bansod
7021aac7ce Try using dynamic wait in TableBrowse and TableStructure
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-18 16:31:20 +05:30
Deven Bansod
ea6f79bf21 Fix createRemoveUser and TableBrowse::DeleteRecords
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-17 17:29:26 +05:30
Deven Bansod
058546d29d Add scrolling to bottom so that click goes through
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-15 17:20:43 +05:30
Deven Bansod
58be76e4e7 Add selenium tests for Query-by-example
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-15 16:10:37 +05:30
Deven Bansod
7e04e04631 Add a small sleep to avoid stale element exception
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-11 16:11:06 +05:30
Deven Bansod
e71c08d792 Add Selenium tests for typing and executing SQL query
* Adds separate tests for Server SQL, Database SQL, Table SQL query pages
* Add tests for inline-edit on SQL results page

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-11 15:23:53 +05:30
Deven Bansod
fca2173b3f Prevent errors in TableExport by scrolling to proper height
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-07 19:57:06 +05:30
Michal Čihař
be2d9b7952 Merge pull request #13526 from devenbansod/fix_import_selenium
Fix Import-related selenium tests
2017-07-31 15:26:58 +02:00
Deven Bansod
8c247a17f8 Don't mark incomplete tests and skipped tests as Failed on browerstack
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-27 18:08:07 +05:30
Deven Bansod
88149373bb Mark failed selenium tests on Browerstack as failed
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-27 17:07:31 +05:30
Deven Bansod
7f830b1094 Prevent possible stale element error in tracking
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-27 17:07:22 +05:30
Deven Bansod
c28e2d4235 Fix Import-related selenium tests
* Use $cfg['uploadDir'] = "./test/test_data" while importing
* Prevents use of FileDetectors in remote file detectors etc.

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-26 20:24:22 +05:30
Deven Bansod
b1504ad3f5 Use shorter strings hoping to avoid error in DbEvents addEvent
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-26 20:18:26 +05:30
Deven Bansod
db79d9f63c Let the SQL query box load completely
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-26 18:58:55 +05:30
Deven Bansod
7467d28198 Use alternate way to enter long text field values in AddEvent
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-26 18:58:47 +05:30
Deven Bansod
467c6405e5 Fix possible errors with DropTracking test
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-26 18:58:38 +05:30
Deven Bansod
e0d89fa22a Use different approach to handle typing long values
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-26 14:39:29 +05:30
Deven Bansod
8ec61c66cd Fix possible infinite loop in TableInsert-addData
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-25 22:04:33 +05:30
Deven Bansod
e6fdb15dc9 Fix failing test in CopyRecords-TableBrowse
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-25 22:04:24 +05:30