1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-28 07:41:55 +03:00
Commit Graph

51 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
28cd3776d2 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
2026-07-31 18:15:28 -03:00
Maurício Meneghini Fauth
6f427d8785 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
2026-07-18 15:26:39 -03:00
Maurício Meneghini Fauth
f6d656b6a3 Fix bookmarks not being properly saved
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
2026-05-22 19:32:03 -03:00
Kamil Tekiela
f708e074c9 Clean up config again (#20264)
* MaxTableList/MaxDbList/QueryHistoryMax
* UserprefsDisallow
* NaturalOrder
* Update TableTest.php
* MaxExactCountViews
* Update ReplicationGuiTest.php
* Update RoutinesTest.php
* Update StructureControllerTest.php
* Update ExportControllerTest.php
* Update StructureControllerTest.php
* Update BookmarkTest.php
* MaxCharactersInDisplayedSQL
* ActionLinksMode/ShowSQL/MysqlSslWarningSafeHosts
* Update TwoFactorTest.php
* ForeignKeyMaxLimit/ForeignKeyDropdownOrder
* QueryHistoryDB
* ZeroConf
* UseDbSearch
* MaxRoutineList
* NumFavoriteTables
* EnableAutocompleteForTablesAndColumns
* MaxExactCount/ShowStats
* InitialSlidersState
* Remove isset in Results
* Remove isset and fix tests
* PmaNoRelation_DisableWarning
* ShowCreateDb
* Update phpstan-baseline.neon
* Navigation
* Upgrading vimeo/psalm (6.15.0 => 6.16.1)

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-04-10 16:33:08 -03:00
William Desportes
2c03905eea Merge #19802 - Fix #19381 - Implement csv empty to null
Pull-request: #19802
Fixes: #19381

Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2026-04-09 16:59:10 +02:00
William Desportes
a46e3f55ca Fix tests after #20227 - for the default storage engine
Pull-request: #20227
Ref: #20171

Signed-off-by: William Desportes <williamdes@wdes.fr>
2026-03-17 13:49:10 +01:00
Maurício Meneghini Fauth
3924c58ed1 Fix failing tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-07 14:13:24 -03:00
Maurício Meneghini Fauth
649c84d251 Add unit test for Database\Structure\AddPrefixTableController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-02 20:46:16 -03:00
Maurício Meneghini Fauth
ba958ae1f7 Add unit test for Database\TrackingController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-02 18:38:07 -03:00
Maurício Meneghini Fauth
c7e93b3934 Add unit test for Database\SqlFormatController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-02 17:58:08 -03:00
Maurício Meneghini Fauth
45ac0da83c Add unit test for Database\SqlController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-02 17:14:27 -03:00
Maurício Meneghini Fauth
e8a7a39c3e Add unit tests for Database\DesignerController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-02 13:52:55 -03:00
Maurício Meneghini Fauth
43feb0e106 Add unit test for Database\SqlAutoCompleteController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-02 12:15:45 -03:00
Maurício Meneghini Fauth
5590a14863 Add unit test for Database\SearchController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-02 11:15:19 -03:00
Maurício Meneghini Fauth
985455a967 Add unit test for Database\MultiTableQueryController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-27 17:34:37 -03:00
Maurício Meneghini Fauth
e1ffe48b50 Add unit test for MultiTableQuery\QueryController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-27 17:34:37 -03:00
Maurício Meneghini Fauth
29ff018baa Add unit test for Database\ImportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-27 17:34:36 -03:00
Maurício Meneghini Fauth
009939f05a Add unit test for Database\ExportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-27 14:14:36 -03:00
Maurício Meneghini Fauth
809acdfae6 Add unit test for Database\DataDictionaryController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-27 11:14:16 -03:00
Maurício Meneghini Fauth
a19dba215f Add unit test for CentralColumns\PopulateColumnsController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-27 10:51:28 -03:00
Maurício Meneghini Fauth
cfd767235c Add unit test for Database\CentralColumnsController
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-27 10:18:34 -03:00
Maurício Meneghini Fauth
b93e747994 Remove method AbstractTestCase::callFunction()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-21 18:01:03 -03:00
Maurício Meneghini Fauth
2dabc839b3 Extract Config dependency from Template class
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-11 22:51:02 -03:00
Kamil Tekiela
d93a3cf022 DI config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-01 21:01:39 +00:00
Kamil Tekiela
e67fe1b145 Execute getTableListPosition only once
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-12-11 00:19:20 +00:00
Kamil Tekiela
b7327d6944 Move request params out of the method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-12-11 00:19:20 +00:00
Kamil Tekiela
7e57731a92 Move getDbInfo()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-12-11 00:19:18 +00:00
Maurício Meneghini Fauth
4354f4b246 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-11-08 19:44:44 -03:00
Maurício Meneghini Fauth
7567aecd73 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-10-17 10:20:27 -03:00
Maurício Meneghini Fauth
09e453c333 Disable ajax for routine, event and trigger list forms
These forms have event listeners for each action, so it's not needed to
have ajax enabled on the form itself.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-08-31 09:50:58 -03:00
Maximilian Krög
8286d5c555 Indent heredocs
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2025-08-18 21:09:05 +02:00
Maurício Meneghini Fauth
65a4eed88f Replace events export jQuery UI's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-05-14 12:51:40 -03:00
Maurício Meneghini Fauth
dd0c8a4c88 Replace events editor jQuery UI's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-05-14 12:42:53 -03:00
Kamil Tekiela
8c62b1a1b5 Use native MySQL paging
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-05-05 16:03:51 -03:00
Maurício Meneghini Fauth
1a25a06d0d Replace Config::getInstance with DI in controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-05-01 21:51:43 -03:00
Kamil Tekiela
0e5b3968b2 Synchronize routines UX
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-04-18 13:22:01 +01:00
Petr Duda
cfb99ea0ce Add paging to Routines page
Related to #16487

Signed-off-by: Petr Duda <petrduda@seznam.cz>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-04-16 20:26:00 -03:00
Maurício Meneghini Fauth
cd26c052eb Replace execute routine jQuery UI's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-04-10 10:36:41 -03:00
Maurício Meneghini Fauth
2ab001b3d7 Replace routines export jQuery UI's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-04-08 18:05:56 -03:00
Maurício Meneghini Fauth
09d77a0e04 Replace routine editor jQuery UI's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-04-08 13:20:09 -03:00
Kamil Tekiela
de3f7bc1dc Create a new controller
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:14:46 +00:00
Kamil Tekiela
6457695ebb Remove unused lines from psalm.xml
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-29 15:12:59 +00:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Maurício Meneghini Fauth
d65d0b220c Remove the Functions JS global object
Exports each function individually and removes the Functions global
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-27 15:38:41 -03:00
Maurício Meneghini Fauth
d2060c56d5 Change InvocableController to always return a Response
When 'null' is returned, ResponseRenderer::response() is called, so
call it early to always return a Response object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-22 15:22:56 -03:00
Maurício Meneghini Fauth
7fa1fc6ea6 Remove ResponseRenderer::disable from CopyFormController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-06 13:22:35 -03:00
Maurício Meneghini Fauth
4d0565b7cd Remove ResponseRenderer::disable from ChangePrefixFormController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-05 20:36:20 -03:00
Maurício Meneghini Fauth
5c7667369f Remove ResponseRenderer::disable from AddPrefixController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-05 19:34:29 -03:00
Maurício Meneghini Fauth
137283f909 Remove unused constructor params from controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:34 -03:00
Kamil Tekiela
82c85d26c0 Clean up of tests (#19067)
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00