webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-11-03 11:53:04 +03:00
Code Activity
124,561 Commits 12 Branches 481 Tags
1e7997b76182fee68b7cb8ff56bd551f29096708
Commit Graph

1200 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
3890d11dd8 Fix some coding style issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 17:18:54 -03:00
Maurício Meneghini Fauth
478b1c03a7 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 13:52:33 -03:00
Maurício Meneghini Fauth
4d1546f7c5 Fix indentation issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 13:41:31 -03:00
Maurício Meneghini Fauth
d01ec6b0b9 Merge pull request #17776 from kamil-tekiela/Fix-PHPStan-issues 
Fix PHPStan issues
 2022-10-15 16:05:50 -03:00
Maurício Meneghini Fauth
f3e31dfdd1 Merge branch 'pokemaobr-push' 
Closes https://github.com/phpmyadmin/phpmyadmin/pull/17791

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-14 23:57:29 -03:00
Rodrigo Pokemaobr
0bd4711eb5 Changing parameters to Parser 
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-14 23:52:12 -03:00
Kamil Tekiela
594454eff2 Replace for loop with foreach 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-14 20:42:42 +01:00
Maurício Meneghini Fauth
4bda7899ab Fix coding standard issues after #17794 merge 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-14 08:44:52 -03:00
Luca Perna
40adf927c5 Move superglobals access to controllers (#17794) 
Related to #16276

Signed-off-by: Luca Perna <luca@perna.rocks>
 2022-10-14 08:34:42 -03:00
Arpit-Gulgulia
4302745a74 Fix:#17769 Signed-off-by: Arpit Jain <arpitgulgulia@gmail.com> 
Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>
 2022-10-13 17:36:20 +00:00
Maurício Meneghini Fauth
8da8d3f8c8 Add types for Config\FormDisplay::save() parameters 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-12 19:19:36 -03:00
Maurício Meneghini Fauth
46fdea0d0e Remove unneeded writing to $_POST in Database\Structure controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-12 18:07:10 -03:00
Maurício Meneghini Fauth
059705f06e Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-11 19:53:54 -03:00
Maurício Meneghini Fauth
72a6045f06 Fix some errors reported by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-11 18:19:07 -03:00
Maurício Meneghini Fauth
4cd6b23007 Add Http\ServerRequest::getQueryParam method 
Similar to the Http\ServerRequest::getParsedBodyParam method, this
method retrives a single parameter from the request query, or the
default value if not available.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-10 23:00:33 -03:00
Maurício Meneghini Fauth
85f9d94f1b Add basic routing system for setup pages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-10 06:54:45 -03:00
Maurício Meneghini Fauth
6e3fa576c6 Use ServerRequest object for setup controller 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-09 17:05:13 -03:00
Maurício Meneghini Fauth
e05c51576c Extract setup entry points into controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-09 16:22:51 -03:00
Maurício Meneghini Fauth
135cd76d3b Fix exception for invalid db and table names for the privileges page 
Related to #17729

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-30 20:49:21 -03:00
Solomon Okunuga
0f9c79ebed Issue #17727 Started refactoring uses of $db and $table (#17729) 
* Issue #17727 Started refactoring uses of $db and $table to use the Objects -
DatabaseName and TableName

Changed uses related to Privileges

Signed-off-by: Solomon Okunuga <soloistic1@gmail.com>

* Apply suggestions from code review

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Signed-off-by: Solomon Okunuga <soloistic1@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-30 19:33:36 -03:00
Maurício Meneghini Fauth
bb97ed988f Reduce usage of the containerBuilder global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-29 22:36:46 -03:00
Maurício Meneghini Fauth
6a9fe03ff2 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-29 00:45:10 -03:00
Maurício Meneghini Fauth
5d9142674d Allow longer cookie encryption keys to be used 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:34:18 -03:00
Maurício Meneghini Fauth
0ed04a6c00 Remove trigger_error calls from HomeController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
(cherry picked from commit c5611531c0)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:33:38 -03:00
Maurício Meneghini Fauth
a56b425a2a Extract /console/bookmark/add action from ImportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-21 00:06:14 -03:00
Maurício Meneghini Fauth
c2018c4c21 Extract /console/bookmark/refresh action from ImportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-20 21:55:28 -03:00
Maurício Meneghini Fauth
2076d52480 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-19 23:26:15 -03:00
Maurício Meneghini Fauth
c51b5fa437 Use DatabaseName for the newname param in OperationsController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-13 20:36:06 -03:00
Maurício Meneghini Fauth
873eb098b9 Remove crlf global variable 
The crlf global variable is only diferent for SQL export method,
otherwise is always the value of the PHP_EOL constant.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-13 14:08:57 -03:00
Maurício Meneghini Fauth
5d74cd134e Get 'newname' param from ServerRequest object 
Instead of the $_POST superglobal in OperationsController and Operations
classes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-12 23:36:07 -03:00
Maurício Meneghini Fauth
d760df02dd Move DBI getEvents method into the Events class 
DatabaseInterface::getEvents -> Database\Events::getDetails

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-10 12:48:44 -03:00
William Desportes
6230c197dd Fix PHP warning on GIS visualization when there is only one GIS column 
```
Warning in ./libraries/classes/Controllers/Table/GisVisualizationController.php#174
 Undefined array key "labelColumn"

Backtrace

Routing.php#191: PhpMyAdmin\Controllers\Table\GisVisualizationController->__invoke(
,
array,
)
./../../../../index.php#43: PhpMyAdmin\Routing::callControllerForRoute(
,
string '/table/gis-visualization',
,
,
)
```
Structure:
- A table with only one GIS column

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-09-10 14:05:34 +02:00
Maurício Meneghini Fauth
81192a142b Move DBI getRoutines method to the Routines class 
DatabaseInterface::getRoutines -> Database\Routines::getDetails

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-09 23:29:26 -03:00
Maurício Meneghini Fauth
d6b72de8aa Improve return type of Index::getPrimary method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 23:25:20 -03:00
Maurício Meneghini Fauth
9d2350d28c Extract dbi global variable from Index::loadIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 21:59:03 -03:00
Kamil Tekiela
f471e7f8e3 Clean up autocomplete controller 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-09-07 15:35:56 +01:00
Kamil Tekiela
f7f8722e1f Refactor insert edit (#17684) 
This is a major redesign of the code that handles these four actions: in-place edit(AJAX), edit of multiple rows, copying of rows, and insertion of new rows. The goal is to make the code easier to read and more understandable.

    I introduced a new DTO for better readability.
    Some of the methods were made private to the model
    The controller has access to two methods for getting the value for INSERT and for UPDATE
    Unfortunately, I have introduced method envy on EditField, but I do not want to move the functionality away from InsertEdit.php
    Unit tests have not improved in readability but I added helpful comments explaining what we are testing. There's probably a way to improve it too.

I will probably merge all commits once I decide it's ready for review.


Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-22 22:39:53 -03:00
Maurício Meneghini Fauth
a2ef27823e Merge pull request #17688 from kamil-tekiela/Fix-table-creation 
Fix table creation

Fixes #17544
 2022-08-18 22:54:53 -03:00
Kamil Tekiela
d14e334176 Update psalm-baseline.xml 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-17 21:20:50 +01:00
Kamil Tekiela
2e126d7f65 Fix table creation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-17 20:31:51 +01:00
Kamil Tekiela
0944221868 Extract moveBackToCallingScript 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-17 19:21:33 +01:00
Kamil Tekiela
6d91494935 Extract doTransformations 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-17 19:21:33 +01:00
Kamil Tekiela
1e70bba883 Fix bug not allowing insertion of set values 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-08 14:33:50 +01:00
Maurício Meneghini Fauth
75cf045fa3 Extract url.php entry point into a route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-06 15:02:49 -03:00
Maurício Meneghini Fauth
8645920f0d Extract normalization's partial dependencies action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 22:49:07 -03:00
Maurício Meneghini Fauth
28d53fe50b Extract normalization's create new column action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 21:38:55 -03:00
Maurício Meneghini Fauth
a37e5681c8 Extract normalization's get columns action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 20:48:48 -03:00
Maurício Meneghini Fauth
c550d41d1d Extract normalization's add new primary action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 16:45:30 -03:00
Maurício Meneghini Fauth
66970049cc Rename NormalizationController to Normalization\MainController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 15:57:05 -03:00
Maurício Meneghini Fauth
a5024edcc5 Extract normalization's move repeating group action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-02 15:31:41 -03:00