1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-23 18:29:15 +03:00

50 Commits

Author SHA1 Message Date
Kamil Tekiela
9b0cc2548e Refactoring of getTablesFull
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-09-16 15:28:54 +01:00
Maurício Meneghini Fauth
28cd3776d2 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
2026-07-31 18:15:28 -03:00
Maurício Meneghini Fauth
79affae9f9 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-04-25 19:10:32 -03:00
Kamil Tekiela
2702f2814e PluginType enum
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-14 22:01:11 +00:00
Kamil Tekiela
977cf11caf Remove unnecessary Config::$instance assignments
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:13 -03:00
Kamil Tekiela
cc6c910d9b Remove setGlobalConfig()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:08 -03:00
Maurício Meneghini Fauth
a15c6d6a47 Extract dependency from Util::userDir()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-30 15:58:55 -03:00
Maurício Meneghini Fauth
270ada1198 Extract Config dependency from export plugins
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-29 12:31:07 -03:00
Maurício Meneghini Fauth
d617866e49 Extract DatabaseInterface dep from export plugins
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-29 11:49:19 -03:00
Maurício Meneghini Fauth
0386b1a0f9 Replace time() with ClockInterface in UserPreferences class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-19 19:22:54 -03:00
Maurício Meneghini Fauth
4eecb4d7ae Extract Config dependency from UserPreferences class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-09 11:45:49 -03:00
Maurício Meneghini Fauth
a7d53fa76d Extract dependencies from UserPreferencesHandler class
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-09 11:39:34 -03:00
Kamil Tekiela
ccedadae8e Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:31:24 +00:00
Kamil Tekiela
829f0f2140 Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
Kamil Tekiela
7c2bfb78ab SeparateFiles
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-12-20 20:03:05 +00:00
Kamil Tekiela
0833498c0e Use DI for the new class
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-11-22 20:19:24 +00:00
Kamil Tekiela
f89bfd594a Replace Export with OutputHandler
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-11-22 20:03:59 +00:00
Kamil Tekiela
29f48465ca Clean up $compression
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-11-22 20:03:59 +00:00
Kamil Tekiela
13b34aa471 OutputHandler
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-11-22 20:03:59 +00:00
Maurício Meneghini Fauth
c82ad3e88a Fix export template update error
When updating an export template, the exportType request parameter is
ignored by the controller, because it's not used by the UPDATE
statement. However the Template value object requires a valid ExportType
enum, causing a ValueError to be thrown.

```
ValueError: "" is not a valid backing value for enum PhpMyAdmin\Plugins\ExportType
```

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-08-30 14:25:47 -03:00
Maximilian Krög
8286d5c555 Indent heredocs
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2025-08-18 21:09:05 +02:00
Maurício Meneghini Fauth
37cbc4b3f3 Extract dependencies from Transformations class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-06-21 14:39:37 -03:00
Maurício Meneghini Fauth
3a619b6824 Remove plugin global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-14 16:25:41 -03:00
Maurício Meneghini Fauth
138c5022fb Remove the single_table global variable
Replaces it with Export::$singleTable static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-08 18:45:42 -03:00
Maurício Meneghini Fauth
ae305d6202 Remove the output_kanji_conversion global variable
Replaces it with Export::$outputKanjiConversion static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-08 02:50:25 -03:00
Maurício Meneghini Fauth
b3df04bcf8 Remove the buffer_needed global variable
Replaces it with Export::$bufferNeeded static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-08 02:26:18 -03:00
Maurício Meneghini Fauth
aad57a864b Remove the asfile global variable
Replaces it with Export::$asFile static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-08 00:27:45 -03:00
Maurício Meneghini Fauth
38f42dab62 Merge pull request #19470 from kamil-tekiela/getColumnsFull
Remove DatabaseInterface::getColumnsFull()
2024-12-25 11:53:10 -03:00
Maurício Meneghini Fauth
5548f8fe5b Replace lang global var with Current::$lang prop
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-24 12:01:03 -03:00
Kamil Tekiela
821bb81af2 Drop getColumnsFull()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-23 17:58:03 +00:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Maurício Meneghini Fauth
75d11f910b Remove sql_* global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-20 19:42:52 -03:00
Maurício Meneghini Fauth
038c59b1bf Remove some sql_* global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-20 12:12:08 -03:00
Maurício Meneghini Fauth
c13d8af2a5 Remove *_comments global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-14 17:59:20 -03:00
Maurício Meneghini Fauth
f9d5612f6b Remove sql_dates global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-14 17:46:13 -03:00
Maurício Meneghini Fauth
6c9e8c4e2e Remove *_mime global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-14 17:44:27 -03:00
Maurício Meneghini Fauth
2009234dfc Remove *_relation global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-14 17:29:10 -03:00
Maurício Meneghini Fauth
9322565d9b Remove *_structure_or_data globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-14 17:17:19 -03:00
Kamil Tekiela
b3ffcc6d6c Remove $exportType param from Export
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-14 02:18:02 +00:00
Kamil Tekiela
24fba67ccd Create ExportType enum
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-14 00:34:12 +00:00
Kamil Tekiela
7dbda7545e Remove $GLOBALS['plugin_param']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-13 23:19:53 +00:00
Kamil Tekiela
1a4f69c13a Drop $errorUrl from exportServer
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-12 23:05:33 +00:00
Kamil Tekiela
ae57858586 Drop $errorUrl from exportDatabase
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-12 23:05:33 +00:00
Kamil Tekiela
acaea01d21 Split up getFinalFilenameAndMimetypeForFilename
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-05 02:31:18 +00:00
Maurício Meneghini Fauth
c10d265ae5 Move flash message context to the shaped array
Does not group the messages by context.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-16 14:41:04 -03:00
Maurício Meneghini Fauth
64a8a9d779 Rename the FlashMessages class to FlashMessenger
This class handles the flash messages instead of being a collection
of flash messages, so FlashMessenger is a better name.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-15 19:42:35 -03:00
Maurício Meneghini Fauth
24fcf259f3 Add support for statement messages in FlashMessages class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-15 19:20:37 -03:00
Kamil Tekiela
82c85d26c0 Clean up of tests (#19067)
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00
Kamil Tekiela
8754b9b0c5 Fix PHPUnit 11 deprecations (#19057)
* Metadata in doc-comments is deprecated

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix deprecated Group('medium') on classes

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix #[Group('large')]

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix some #[Group('medium')]

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in NodeDatabaseChildTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in PropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyGroupTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in PluginPropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in GisGeometryTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove getMockForAbstractClass from StorageEngineTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyOneItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-17 13:35:28 -03:00
Maurício Meneghini Fauth
606f66b5df Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00