1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-23 18:29:15 +03:00

36 Commits

Author SHA1 Message Date
Kamil Tekiela
27983858dc Replace random_int(0, mt_getrandmax())
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-09-24 23:50:21 +01:00
Maurício Meneghini Fauth
1c2266154c Merge pull request #20441 from kamil-tekiela/Message-refactoring
Message refactoring
2026-08-30 18:25:07 -03:00
Kamil Tekiela
553e642367 Pass Statement in Result
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-08-24 17:29:35 +01:00
Kamil Tekiela
0970bb1575 Pass only Message to getMessage
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-08-22 23:34:37 +01:00
Maurício Meneghini Fauth
28cd3776d2 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
2026-07-31 18:15:28 -03:00
Maurício Meneghini Fauth
b93e747994 Remove method AbstractTestCase::callFunction()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-21 18:01:03 -03:00
Maurício Meneghini Fauth
58989b0beb Fix Display\ResultsTest failing test
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-20 17:13:00 -03:00
Maurício Meneghini Fauth
1eff7e56af Merge pull request #20136 from kamil-tekiela/Fix-Config-tests
Fix config in tests
2026-02-20 15:14:21 -03:00
Kamil Tekiela
90caa57986 Remove all unnecessary tearDown
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 22:24:48 +00:00
Kamil Tekiela
50d6d626f2 Fix ProtectBinary
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 22:00:41 +00:00
Kamil Tekiela
3c3fb32237 Fix LimitChars
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 21:55:05 +00:00
Kamil Tekiela
97b4f16c97 Fix Order
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 21:44:30 +00:00
Maurício Meneghini Fauth
48ca010684 Extract ResponseRenderer dependency from Display\Results
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-14 17:03:06 -03:00
Maurício Meneghini Fauth
b6751c41ef Extract dependency from ParseAnalyze::sqlQuery()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-13 21:22:13 -03:00
Maurício Meneghini Fauth
2dabc839b3 Extract Config dependency from Template class
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-11 22:51:02 -03:00
Kamil Tekiela
cc6c910d9b Remove setGlobalConfig()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:08 -03:00
Maurício Meneghini Fauth
190de2a439 Replace request globals with ServerRequest in Display\Results class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-15 15:24:52 -03:00
Kamil Tekiela
829f0f2140 Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
Kamil Tekiela
1e66018a6e DataProvider types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-10-12 20:06:00 -03:00
Maurício Meneghini Fauth
44bcf98a43 Extract string constants from RelationParameters class
These strings are very similar to some Config\Settings\Server
properties, so is better to avoid confusion.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-08-05 18:26:40 -03:00
Maurício Meneghini Fauth
37cbc4b3f3 Extract dependencies from Transformations class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-06-21 14:39:37 -03:00
Maurício Meneghini Fauth
063555083e Merge PR #19361 Column sorting does not work when names contain dots
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-02-21 20:17:14 -03:00
Kamil Tekiela
44a8e6ffb6 Split up getPartialText()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-18 01:04:31 +00:00
Kamil Tekiela
c86d9154e2 Refactor to lex only once
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-13 01:33:40 +00:00
Kamil Tekiela
8b988474a9 Update ResultsTest.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-13 01:30:58 +00:00
Kamil Tekiela
19e3a117b0 Update ResultsTest.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-13 01:30:58 +00:00
Maurício Meneghini Fauth
081d6c13d0 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-25 12:37:15 -03:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
2874235f7d Fix explode (#19377)
* Fix explode
* RemoveAlwaysTrueIfConditionRector

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:34:04 -03:00
Maurício Meneghini Fauth
fdfe7a92e9 Upgrade phpmyadmin/sql-parser
- Upgrading phpmyadmin/sql-parser (dev-master 3bc8d0d => dev-master f2bafbb)
  - Upgrading roave/security-advisories (dev-latest 8938260 => dev-latest f8de2a8)

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-08-25 16:03:42 -03:00
Maurício Meneghini Fauth
70105294ef Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-22 15:44:41 -03:00
Maurício Meneghini Fauth
90ee00efd5 Create the 'pma' global variable for Twig templates
Creates the Twig\PmaGlobalVariable class to handle the 'pma' Twig global
variable.

The idea of this global variable is to automatically inject in all
templates some useful information.

For now it only includes `pma.version` to get the phpMyAdmin version
and `pma.text_dir` to get the text direction ('ltr' or 'rtl').

Adding new variables to the `pma` global variable should be done with
caution.

- https://twig.symfony.com/doc/3.x/advanced.html#globals

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-09 20:30:48 -03:00
Maurício Meneghini Fauth
1db76c69f1 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-03 22:04:18 -03:00
Kamil Tekiela
99c4d34db2 Create MessageType enum
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-05-14 16:30:45 +02:00
Kamil Tekiela
82c85d26c0 Clean up of tests (#19067)
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00
Maurício Meneghini Fauth
606f66b5df Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00