1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-23 18:29:15 +03:00

33 Commits

Author SHA1 Message Date
Kamil Tekiela
9b0cc2548e Refactoring of getTablesFull
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-09-16 15:28:54 +01:00
Maurício Meneghini Fauth
84be8f61eb Merge pull request #20417 from kamil-tekiela/Rector-fixes
Rector fixes
2026-08-13 10:17:13 -03:00
Maurício Meneghini Fauth
3b4defeb35 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
2026-08-13 09:57:18 -03:00
Kamil Tekiela
63bba57910 NarrowUnusedSetUpDefinedPropertyRector
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-08-12 14:18:48 +01:00
Maurício Meneghini Fauth
28cd3776d2 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
2026-07-31 18:15:28 -03:00
Kamil Tekiela
f708e074c9 Clean up config again (#20264)
* MaxTableList/MaxDbList/QueryHistoryMax
* UserprefsDisallow
* NaturalOrder
* Update TableTest.php
* MaxExactCountViews
* Update ReplicationGuiTest.php
* Update RoutinesTest.php
* Update StructureControllerTest.php
* Update ExportControllerTest.php
* Update StructureControllerTest.php
* Update BookmarkTest.php
* MaxCharactersInDisplayedSQL
* ActionLinksMode/ShowSQL/MysqlSslWarningSafeHosts
* Update TwoFactorTest.php
* ForeignKeyMaxLimit/ForeignKeyDropdownOrder
* QueryHistoryDB
* ZeroConf
* UseDbSearch
* MaxRoutineList
* NumFavoriteTables
* EnableAutocompleteForTablesAndColumns
* MaxExactCount/ShowStats
* InitialSlidersState
* Remove isset in Results
* Remove isset and fix tests
* PmaNoRelation_DisableWarning
* ShowCreateDb
* Update phpstan-baseline.neon
* Navigation
* Upgrading vimeo/psalm (6.15.0 => 6.16.1)

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-04-10 16:33:08 -03:00
Maurício Meneghini Fauth
2dabc839b3 Extract Config dependency from Template class
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-11 22:51:02 -03:00
Maurício Meneghini Fauth
21ae1694a6 Extract dependencies from Util::expandUserString()
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-30 15:21:07 -03:00
William Desportes
dc1408701f Merge #19997 - Fix Export checkboxes
Pull-request: #19997
Signed-off-by: William Desportes <williamdes@wdes.fr>
2026-01-25 19:44:47 +01:00
Maurício Meneghini Fauth
0386b1a0f9 Replace time() with ClockInterface in UserPreferences class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-19 19:22:54 -03:00
Kamil Tekiela
259e9fa542 Shorten checkbox value
We don't need any value, but to keep the code as is, we need at least one byte. Shorter value means less bytes transferred over network.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-17 15:30:03 +00:00
Kamil Tekiela
6bc3a22b57 Use private instead of protected
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-14 14:28:40 +00:00
Maurício Meneghini Fauth
4eecb4d7ae Extract Config dependency from UserPreferences class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-09 11:45:49 -03:00
Maurício Meneghini Fauth
a7d53fa76d Extract dependencies from UserPreferencesHandler class
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-09 11:39:34 -03:00
Kamil Tekiela
829f0f2140 Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
Kamil Tekiela
0833498c0e Use DI for the new class
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-11-22 20:19:24 +00:00
Maurício Meneghini Fauth
c82ad3e88a Fix export template update error
When updating an export template, the exportType request parameter is
ignored by the controller, because it's not used by the UPDATE
statement. However the Template value object requires a valid ExportType
enum, causing a ValueError to be thrown.

```
ValueError: "" is not a valid backing value for enum PhpMyAdmin\Plugins\ExportType
```

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-08-30 14:25:47 -03:00
Maurício Meneghini Fauth
44bcf98a43 Extract string constants from RelationParameters class
These strings are very similar to some Config\Settings\Server
properties, so is better to avoid confusion.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-08-05 18:26:40 -03:00
Maurício Meneghini Fauth
a82b8e22a8 Add static analysis stub for PSR ContainerInterface
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-07-15 18:37:24 -03:00
Maurício Meneghini Fauth
1a25a06d0d Replace Config::getInstance with DI in controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-05-01 21:51:43 -03:00
Maurício Meneghini Fauth
a2b07b92ee Upgrade PHPUnit to version 11.5
- Upgrading amphp/amp (v3.0.2 => v3.1.0)
  - Upgrading phpmyadmin/sql-parser (dev-master ab0d173 => dev-master 00c8e55)
  - Upgrading phpstan/phpstan-phpunit (2.0.3 => 2.0.4)
  - Upgrading phpunit/php-code-coverage (10.1.16 => 11.0.8)
  - Upgrading phpunit/php-file-iterator (4.1.0 => 5.1.0)
  - Upgrading phpunit/php-invoker (4.0.0 => 5.0.1)
  - Upgrading phpunit/php-text-template (3.0.1 => 4.0.1)
  - Upgrading phpunit/php-timer (6.0.0 => 7.0.1)
  - Upgrading phpunit/phpunit (10.5.41 => 11.5.4)
  - Upgrading roave/security-advisories (dev-latest e7a38fc => dev-latest 3f5a01e)
  - Upgrading sebastian/cli-parser (2.0.1 => 3.0.2)
  - Upgrading sebastian/code-unit (2.0.0 => 3.0.2)
  - Upgrading sebastian/code-unit-reverse-lookup (3.0.0 => 4.0.1)
  - Upgrading sebastian/comparator (5.0.3 => 6.3.0)
  - Upgrading sebastian/complexity (3.2.0 => 4.0.1)
  - Upgrading sebastian/diff (5.1.1 => 6.0.2)
  - Upgrading sebastian/environment (6.1.0 => 7.2.0)
  - Upgrading sebastian/exporter (5.1.2 => 6.3.0)
  - Upgrading sebastian/global-state (6.0.2 => 7.0.2)
  - Upgrading sebastian/lines-of-code (2.0.2 => 3.0.1)
  - Upgrading sebastian/object-enumerator (5.0.0 => 6.0.1)
  - Upgrading sebastian/object-reflector (3.0.0 => 4.0.1)
  - Upgrading sebastian/recursion-context (5.0.0 => 6.0.2)
  - Upgrading sebastian/type (4.0.0 => 5.1.0)
  - Upgrading sebastian/version (4.0.1 => 5.0.2)
  - Upgrading squizlabs/php_codesniffer (3.11.2 => 3.11.3)
  - Locking staabm/side-effects-detector (1.0.5)
  - Upgrading tecnickcom/tcpdf (6.8.0 => 6.8.2)

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-28 18:43:58 -03:00
Maurício Meneghini Fauth
5548f8fe5b Replace lang global var with Current::$lang prop
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-24 12:01:03 -03:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Maurício Meneghini Fauth
038c59b1bf Remove some sql_* global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-20 12:12:08 -03:00
Kamil Tekiela
24fba67ccd Create ExportType enum
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-14 00:34:12 +00:00
Kamil Tekiela
cf6d5ed4b5 Use getParsedBodyParamAsString (#19333)
* Use getParsedBodyParamAsString
* Remove unused stubs

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-10-29 12:07:39 -03:00
Maurício Meneghini Fauth
70105294ef Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-22 15:44:41 -03:00
Maurício Meneghini Fauth
d2060c56d5 Change InvocableController to always return a Response
When 'null' is returned, ResponseRenderer::response() is called, so
call it early to always return a Response object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-22 15:22:56 -03:00
Maurício Meneghini Fauth
e3c4e9998d Remove ResponseRenderer::disable from Export\ExportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-13 16:44:36 -03:00
Maurício Meneghini Fauth
278c68b15b Add unit test for ExportController download file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-13 16:22:23 -03:00
Kamil Tekiela
34caf80af1 Replace $GLOBALS with public properties
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 23:35:46 +02:00
Maurício Meneghini Fauth
137283f909 Remove unused constructor params from controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:34 -03:00
Maurício Meneghini Fauth
606f66b5df Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00