webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-23 18:29:15 +03:00
Code Activity
137,012 Commits 12 Branches 481 Tags
master
Commit Graph

67 Commits

Author SHA1 Message Date
Kamil Tekiela
b42ba11315 Fix missing db parameters errors 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-10-20 00:24:19 +01:00
Kamil Tekiela
ea3c53e199 Remove ajax_request 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-10-19 02:05:05 +01:00
Maurício Meneghini Fauth
fc3c643dc8 Move Database\EventsController to Events\IndexController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
 2026-10-12 11:46:51 -03:00
Maurício Meneghini Fauth
00418f6507 Extract EventsControllerTest fixtures into files 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
 2026-10-12 11:22:23 -03:00
Kamil Tekiela
1028e79fe4 Refactor DataDictionaryController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-09-29 21:29:14 +01:00
Kamil Tekiela
2bd0ac4b38 Replace Twig Random 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-09-25 00:07:48 +01:00
Kamil Tekiela
6aa3747078 Refactor Ajax class 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-09-24 23:42:29 +01:00
Maurício Meneghini Fauth
40b167a5d0 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
 2026-09-19 14:22:17 -03:00
Kamil Tekiela
ccc28ce3fa Add tests for getDbInfo table group filtering 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
 2026-09-16 15:40:43 +01:00
Kamil Tekiela
21e133ebc0 Stop pinning table group to the top 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-09-16 15:40:43 +01:00
Kamil Tekiela
a149087626 Fix bug when fetching table groups 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-09-16 15:28:54 +01:00
Kamil Tekiela
9b0cc2548e Refactoring of getTablesFull 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-09-16 15:28:54 +01:00
Kamil Tekiela
cb7a87d115 Introduce TableType enum for table list type filtering 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-09-16 15:28:54 +01:00
Kamil Tekiela
9b9ed5485b Fix table list position handling in Database StructureController 
Clamp negative pos parameters to 0 in getTableListPosition(); a
negative value used to be stored in the session and end up as a
negative array_slice() offset or an invalid negative SQL OFFSET.

Redirect to the last page when the position is exactly equal to the
total number of tables: such a page is empty, but the previous check
only redirected when the position was strictly greater, rendering an
empty table list for a non-empty database.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-09-16 15:28:54 +01:00
Kamil Tekiela
fbf5158b2b Remove the position field from Database StructureController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-09-16 15:28:54 +01:00
Kamil Tekiela
c7f37ee42f Refactor StructureController::getDbInfo() and expand its test coverage 
Add unit tests for the previously untested paths of getDbInfo(): sort
name mapping (including descending order and unknown sort columns),
the tbl_group and tbl_type filters, and MaxTableList paging.

Refactor getDbInfo() into three flat branches, replacing the
string|false $groupWithSeparator juggling and the duplicated string
checks. The sort name is now mapped with a match expression. The paging
position is passed as an explicit parameter instead of being read from
a private field, and the total table count is always returned as an int
instead of int|null, so the caller no longer needs a fallback count.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-09-16 15:28:53 +01:00
Maurício Meneghini Fauth
28cd3776d2 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
 2026-07-31 18:15:28 -03:00
Maurício Meneghini Fauth
6f427d8785 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
 2026-07-18 15:26:39 -03:00
Maurício Meneghini Fauth
f6d656b6a3 Fix bookmarks not being properly saved 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
 2026-05-22 19:32:03 -03:00
Kamil Tekiela
f708e074c9 Clean up config again (#20264) 
* MaxTableList/MaxDbList/QueryHistoryMax
* UserprefsDisallow
* NaturalOrder
* Update TableTest.php
* MaxExactCountViews
* Update ReplicationGuiTest.php
* Update RoutinesTest.php
* Update StructureControllerTest.php
* Update ExportControllerTest.php
* Update StructureControllerTest.php
* Update BookmarkTest.php
* MaxCharactersInDisplayedSQL
* ActionLinksMode/ShowSQL/MysqlSslWarningSafeHosts
* Update TwoFactorTest.php
* ForeignKeyMaxLimit/ForeignKeyDropdownOrder
* QueryHistoryDB
* ZeroConf
* UseDbSearch
* MaxRoutineList
* NumFavoriteTables
* EnableAutocompleteForTablesAndColumns
* MaxExactCount/ShowStats
* InitialSlidersState
* Remove isset in Results
* Remove isset and fix tests
* PmaNoRelation_DisableWarning
* ShowCreateDb
* Update phpstan-baseline.neon
* Navigation
* Upgrading vimeo/psalm (6.15.0 => 6.16.1)

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-04-10 16:33:08 -03:00
William Desportes
2c03905eea Merge #19802 - Fix #19381 - Implement csv empty to null 
Pull-request: #19802
Fixes: #19381

Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2026-04-09 16:59:10 +02:00
William Desportes
a46e3f55ca Fix tests after #20227 - for the default storage engine 
Pull-request: #20227
Ref: #20171

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2026-03-17 13:49:10 +01:00
Maurício Meneghini Fauth
3924c58ed1 Fix failing tests 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-03-07 14:13:24 -03:00
Maurício Meneghini Fauth
649c84d251 Add unit test for Database\Structure\AddPrefixTableController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-03-02 20:46:16 -03:00
Maurício Meneghini Fauth
ba958ae1f7 Add unit test for Database\TrackingController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-03-02 18:38:07 -03:00
Maurício Meneghini Fauth
c7e93b3934 Add unit test for Database\SqlFormatController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-03-02 17:58:08 -03:00
Maurício Meneghini Fauth
45ac0da83c Add unit test for Database\SqlController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-03-02 17:14:27 -03:00
Maurício Meneghini Fauth
e8a7a39c3e Add unit tests for Database\DesignerController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-03-02 13:52:55 -03:00
Maurício Meneghini Fauth
43feb0e106 Add unit test for Database\SqlAutoCompleteController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-03-02 12:15:45 -03:00
Maurício Meneghini Fauth
5590a14863 Add unit test for Database\SearchController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-03-02 11:15:19 -03:00
Maurício Meneghini Fauth
985455a967 Add unit test for Database\MultiTableQueryController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-02-27 17:34:37 -03:00
Maurício Meneghini Fauth
e1ffe48b50 Add unit test for MultiTableQuery\QueryController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-02-27 17:34:37 -03:00
Maurício Meneghini Fauth
29ff018baa Add unit test for Database\ImportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-02-27 17:34:36 -03:00
Maurício Meneghini Fauth
009939f05a Add unit test for Database\ExportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-02-27 14:14:36 -03:00
Maurício Meneghini Fauth
809acdfae6 Add unit test for Database\DataDictionaryController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-02-27 11:14:16 -03:00
Maurício Meneghini Fauth
a19dba215f Add unit test for CentralColumns\PopulateColumnsController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-02-27 10:51:28 -03:00
Maurício Meneghini Fauth
cfd767235c Add unit test for Database\CentralColumnsController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-02-27 10:18:34 -03:00
Maurício Meneghini Fauth
b93e747994 Remove method AbstractTestCase::callFunction() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-02-21 18:01:03 -03:00
Maurício Meneghini Fauth
2dabc839b3 Extract Config dependency from Template class 
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-02-11 22:51:02 -03:00
Kamil Tekiela
d93a3cf022 DI config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-01 21:01:39 +00:00
Kamil Tekiela
e67fe1b145 Execute getTableListPosition only once 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-11 00:19:20 +00:00
Kamil Tekiela
b7327d6944 Move request params out of the method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-11 00:19:20 +00:00
Kamil Tekiela
7e57731a92 Move getDbInfo() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-11 00:19:18 +00:00
Maurício Meneghini Fauth
4354f4b246 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-11-08 19:44:44 -03:00
Maurício Meneghini Fauth
7567aecd73 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-10-17 10:20:27 -03:00
Maurício Meneghini Fauth
09e453c333 Disable ajax for routine, event and trigger list forms 
These forms have event listeners for each action, so it's not needed to
have ajax enabled on the form itself.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-31 09:50:58 -03:00
Maximilian Krög
8286d5c555 Indent heredocs 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2025-08-18 21:09:05 +02:00
Maurício Meneghini Fauth
65a4eed88f Replace events export jQuery UI's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-14 12:51:40 -03:00
Maurício Meneghini Fauth
dd0c8a4c88 Replace events editor jQuery UI's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-14 12:42:53 -03:00
Kamil Tekiela
8c62b1a1b5 Use native MySQL paging 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-05 16:03:51 -03:00