webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-25 06:39:48 +03:00
Code Activity
127,988 Commits 12 Branches 481 Tags
STABLE
Commit Graph

147 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
7a5ad92e5f Fix collation error when checking for grant permission 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-09-22 17:40:39 -03:00
Maximilian Krög
a8249efd9b Fix linting errors 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2025-09-04 01:06:42 +02:00
Maurício Meneghini Fauth
e8c216b17e Fix PHP 8.5 Reflection*::setAccessible() deprecations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-17 13:32:00 -03:00
Maximilian Krög
0c6d29358a Fix move column for table with foreign key 
Signed-off-by: Maximilian Krög <maximilian.kroeg@geocept.com>
 2025-07-09 16:41:57 +02:00
Maurício Meneghini Fauth
555ea56cbd Make PHPUnit's assertions stricter 
Backports #18993 to QA_5_2.

This makes merging QA_5_2 into master easier.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-10-12 15:33:45 -03:00
Maurício Meneghini Fauth
7fc96d6621 Call PHPUnit static methods using static calls 
Backports #18907 to QA_5_2.

This makes merging QA_5_2 into master easier.
Changes done using Rector.

- #18907

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-10-12 14:28:22 -03:00
Maximilian Krög
3b992e6a13 Preserve check constraint during column move 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2024-04-19 22:01:43 +02:00
Maurício Meneghini Fauth
a850e44479 Add unit test Table\IndexRenameController class 
Adds unit test for preview SQL button when renaming an index and using
an old MySQL server.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-30 20:49:01 -03:00
Maurício Meneghini Fauth
dbe3db564e Fix Enum/Set editor error when creating a new column 
Fixes #17551

https://github.com/phpmyadmin/phpmyadmin/issues/17551#issuecomment-1136074722

Co-authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-20 20:54:07 -03:00
Ankush Patil
987cb5043d fixed find replace regex issue if no matching result set found 
When find and replace searching used with regex, at the time of replace
empty CASE END condition was causing issue.

Fixes #17388
Closes #17641

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-19 15:28:43 -03:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
44fe103b9c Remove @access annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-22 11:43:45 -03:00
Maurício Meneghini Fauth
bf49480160 Populate relation Session with RelationParameters class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:15 -03:00
Maurício Meneghini Fauth
aaee7961c1 Remove Template dependency from Relation class 
Related to 2299a62e49.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
c411121fd8 Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
e936cad542 Add basic test for Table\OperationsController class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-01 11:47:19 -03:00
Maurício Meneghini Fauth
b2a51c4d84 Create the RelationParameters value object 
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
67e96cf40c Get default config values from Config\Settings classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
3e0856c77b Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
00cb1b3668 Extract IndexesController::doSaveData method 
Creates the Table\Indexes class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-11 14:38:44 -03:00
Maurício Meneghini Fauth
fb257e5922 Extract actions from Table\StructureController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-09 13:48:07 -03:00
Maurício Meneghini Fauth
a2ed4dfe68 Make controllers callable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-30 13:16:29 -03:00
William Desportes
2c28a715b4 Add methods to DbiDummy and AbstractTestCase to control changing databases 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-24 02:01:00 +02:00
William Desportes
8f77a9f29d Ref #15247 - Remove defined('TESTSUITE') from ReplaceController and remove an exit 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-15 02:39:14 +02:00
Maurício Meneghini Fauth
355f6d9d20 Remove PhpMyAdmin\Config::enableBc method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
9adaa912e1 Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
William Desportes
3112321d26 Remove static from SearchControllerTest::testGetDataRowAction 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-16 02:03:28 +02:00
Maurício Meneghini Fauth
f3b79d83c0 Add PHPUnit's Covers annotation on test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
1c084de30b Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
b4f3a2c8aa Fix some failing PHPUnit tests 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-02 14:53:17 -03:00
Maurício Meneghini Fauth
5b2957bdc1 Add a redirection after dropping a column 
Instead of loading the page in the same action, redirect to the table
structure page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-07 11:24:12 -03:00
Maurício Meneghini Fauth
44bdd1d390 Rename $url_params global to $urlParams 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-24 22:48:14 -03:00
Maurício Meneghini Fauth
33d711215d Remove the PMA_VERSION constant 
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5 Rename the PMA_Config global variable to config 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 15:03:12 -03:00
William Desportes
7bd3ec6b35 Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-06 21:25:54 +01:00
William Desportes
69e7436aef Edit the test for #16708 to cover more code and have better assertions 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-06 21:19:09 +01:00
William Desportes
13fdc3e099 Add tests for #16708 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-06 19:30:14 +01:00
William Desportes
f1ad006701 Fix a failing test when using phpunit filter 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-06 19:12:43 +01:00
Maurício Meneghini Fauth
0b8edc5bde Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
William Desportes
c5155ecae9 Refactor field flags to use an object an not strpos 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-24 23:56:33 +01:00
William Desportes
0a1d09b282 Add tests for #16595 - underscore structure edit 
I removed the escape because it is already escaped afterwards.

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-31 01:25:34 +01:00
William Desportes
3dad3b5e5d Merge #15912 - Fix #14953 - Added Rename Button to use RENAME INDEX syntax of MySQL 
Issue: #14953
Pull-request: #15912
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-13 23:47:33 +01:00
William Desportes
50e900a1bf Remove all @test annotations 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-08 23:01:26 +01:00
William Desportes
ea10267882 Fix tests after feature 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-05 15:50:43 +01:00
Maurício Meneghini Fauth
4873c32273 Remove DatabaseInterface::isUserType method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-25 20:53:50 -03:00
Maurício Meneghini Fauth
71d9a8f760 Remove is_grantuser and is_createuser PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
601ed4649e Remove DBI dep from Table\AbstractController 
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-12 12:53:03 -03:00
William Desportes
777dcb2e60 Fix coding standard issues 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-10-11 18:13:35 +02:00