webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-25 06:39:48 +03:00
Code Activity
127,988 Commits 12 Branches 481 Tags
STABLE
Commit Graph

51 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
7a5ad92e5f Fix collation error when checking for grant permission 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-09-22 17:40:39 -03:00
Maurício Meneghini Fauth
016fb0c095 Revert "Fix #19109 - Do not enforce character encoding when checking roles" 
This reverts commit 0878841fba.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-09-17 20:15:41 -03:00
Daniel Schindler
0878841fba Fix #19109 - Do not enforce character encoding when checking roles 
The functions `getInformationSchemaDataForCreateRequest()` and `getInformationSchemaDataForGranteeRequest()` generate a query that fails with the error `COLLATION 'utf8mb4_general_ci' is not valid for CHARACTER SET 'utf8mb3'` on some servers that got migrated from MySql 5.7. This lead to admin users not being able to create new users via PhpMyAdmin's UI. Instead, the error message "You do not have the privileges to administrate the users!" is being shown. When not forcing the encoding to `utf8mb4_general_ci` in the query, everything works fine.

Signed-off-by: Daniel Schindler<post@danielschindler.de>
 2025-09-14 18:48:52 +02:00
Maurício Meneghini Fauth
12efd0a0fe Replace replication statements with new terminology 
SHOW MASTER LOGS was removed in MySQL 8.4.0 and SHOW BINARY LOGS is
available since MySQL 4.1.1.

As of MySQL 8.2.0, SHOW BINARY LOG STATUS is available.
As of MariaDB 10.5.2, SHOW BINLOG STATUS is available.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-10-31 13:50:11 -03:00
Luca Camillo
78335aac87 Add role based auth for MySQL 8.x and compatibles (#18814) 
* add role based auth for mysql 8.x or compatible like mariadb/aws rds aurora mysql

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* Using cache and check server version

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* implement tests for getCurrentRolesAndHost / getCurrentRoles functions

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* fix role checks on mariadb

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* Simplify code + ignore NONE as result of CURRENT_ROLE()

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Fixes #18782

---------

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-03-02 19:31:03 -03:00
Kamil Tekiela
e9b9c120af Fix getTablesFull() and related tests 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-15 19:59:35 +00:00
Kamil Tekiela
3db245f462 Optimize export of many tables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-15 19:59:35 +00:00
William Desportes
6d482de7b8 Add back UUID and UUID_SHORT to functions on MySQL and all MariaDB versions 
Ref: https://github.com/phpmyadmin/phpmyadmin/pull/17767

It was a mistake to remove the UUID functions, they are not the UUID type

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-01-20 20:18:55 +04:00
William Desportes
e28bc2d8f6 Fix #17446 - Missing option for STORED virtual column and lower the check to MySQL>=5.7.6. Nothing is supported on 5.7.5. 
Fixes: #17446

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 18:08:35 +01:00
Mo Sureerat
7dc3607581 Improve code & comment 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-10-11 19:23:22 +07:00
Mo Sureerat
a07474f997 Handle array re-index + fix setVersion logic + hardcode version int 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-10-11 17:32:03 +07:00
Mo Sureerat
8c93351647 Relocate method and fix unit test fail 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-10-11 01:18:52 +07:00
William Desportes
70a067ad09 Move compatibility logic into the Compatibility class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-09-30 23:26:54 +02:00
William Desportes
d0093468d0 Fix escaping of SQL query and errors for debug console 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-08-15 13:20:09 +02:00
Maurício Meneghini Fauth
7b1dd0ea6c Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-12 11:42:17 -03:00
William Desportes
0c890adb60 Fix #17287 - Sorting Database List on "Data" Column creates a PHP type error 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-02-11 22:24:45 +01:00
Kamil Tekiela
b8f6fce3ef Fix parameter types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 23:09:56 +00:00
Maurício Meneghini Fauth
feca48cc76 Change return type of DatabaseInterface::getError method 
Now, it returns last error message or an empty string instead of false
if no errors occurred.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
3e0856c77b Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
f7fc4177af Add support for account locking 
- https://dev.mysql.com/doc/refman/en/account-locking.html
- https://mariadb.com/kb/en/account-locking/

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-21 00:55:33 -03:00
William Desportes
72800e2524 Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-15 00:52:33 +02:00
William Desportes
d804e60820 Fix broken docs link after FK types mismatch error 
See: https://web.archive.org/web/20200921164945/https://dev.mysql.com/doc/refman/8.0/en/innodb-foreign-key-constraints.html

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-14 15:28:55 +02:00
William Desportes
1b2f0626c7 Ref #16842 - Remove the function Compatibility::isMySql because only Compatibility::isMySqlOrPerconaDb should be used 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-22 18:47:30 +02:00
Fawzi E. Abdulfattah
9954c47577 Fix #16138 - ignore the length of integer types, and show a warning 
Fixes: #16138

Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
 2021-07-13 15:42:57 +02:00
Maurício Meneghini Fauth
6ae07c96fb Replace strpos !== false with str_contains 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
1c084de30b Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
8d0c2a339c Move both operands of an assignment to the same line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-20 22:35:21 -03:00
William Desportes
aaaff9c307 Extract some compatiblity checks into the Query\Compatibility class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 21:02:50 +02:00
William Desportes
41e0d4dfb7 Use the Query\Compatibility class to simply and remove duplicate checks 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 20:57:10 +02:00
William Desportes
d99da46f7a Move isVirtualColumnsSupported to Query\Compatibility and simplify the code 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 20:31:38 +02:00
William Desportes
7aabad9b7a Move queries from Operations class to the Query\Generator class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-06 02:11:25 +01:00
Maurício Meneghini Fauth
d83abf63e7 Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
William Desportes
2acea7d4c0 Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-31 01:39:50 +01:00
William Desportes
2bc0b80cb9 Fix a phpdoc block and a coding standard issue 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-31 01:23:46 +01:00
William Desportes
9abf4cb109 Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-22 00:37:51 +01:00
Prashant Tholia
ebff28171c Fix #16463 - 'REFERENCES' privilege checkbox's title 
Set different title messages depending on database and database version for 'REFERENCES' field in user 'Edit Preferences' form.

Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: Prashant Tholia <prashant.tholia@gmail.com>
 2021-01-22 00:05:43 +01:00
Maurício Meneghini Fauth
2625e0e1f6 Replace .caution and .success CSS classes 
Replaces with .text-danger and .text-success.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-12-23 19:37:52 -03:00
Kartik Kathuria
b2039444bf Fixes #14953 - Added Rename Button to use RENAME INDEX syntax of MySQL 
Co-Authored-By: William Desportes <williamdes@wdes.fr>

Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
 2020-11-05 15:22:16 +01:00
William Desportes
36fa925914 Extract SQL query from DatabaseInterface::getColumnsFull 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 15:08:36 +02:00
William Desportes
73fb678d08 Extract SQL query from DatabaseInterface::getDatabasesFull 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 15:01:58 +02:00
William Desportes
8e164bda85 Move _dbgQuery to Query\Utilities as debugLogQueryIntoSession 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 14:47:39 +02:00
William Desportes
eecab19b3e Move versionToInt to Query\Utilities 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 14:18:03 +02:00
William Desportes
aadb6abfeb Move usortComparisonCallback to Query\Utilities and remove 2 globals 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 10:34:02 +02:00
William Desportes
7e9d2ae4f9 Move more SQL queries into Query\Generator 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 02:16:02 +02:00
William Desportes
585304b685 Move formatError into Query\Utilities 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 01:44:02 +02:00
William Desportes
761045bcc9 Move getSystemSchemas and isSystemSchema to Query\Utilities 
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 01:42:53 +02:00
William Desportes
312bf572f2 Move some compatibility handling into Query\Compatibility 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 01:26:07 +02:00
Maurício Meneghini Fauth
199e3d9813 Fix coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 21:08:55 -03:00