webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-25 06:39:48 +03:00
Code Activity
127,988 Commits 12 Branches 481 Tags
STABLE
Commit Graph

85 Commits

Author SHA1 Message Date
Liviu-Mihail Concioiu
81f550c693 Fix syntax error 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2025-09-22 17:35:23 +02:00
Liviu-Mihail Concioiu
b5fb37b939 Fix #19570 - Check for HTTP_HOST and document the issue in FAQ (#19858) 
Fixes #19570

* Check for HTTP_HOST and document the issue in FAQ

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Remove whitespace

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Update libraries/classes/Controllers/HomeController.php

Co-authored-by: William Desportes <williamdes@wdes.fr>

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
Co-authored-by: William Desportes <williamdes@wdes.fr>
 2025-09-14 16:00:21 -03:00
Mattia Rizzolo
3dfaed3554 Fix inverted logic hide serverlist (#18021) 
* Reflow lines to arguably better understand the logic

There are a bit too many branch in this single line..

Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>

* Fix inverted logic in the serverlist in the home page

Here the server list was visible when it wasn't supposed to be, and
hidden when it was supposed to be visible.

Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>

---------

Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-04-29 21:21:36 -03:00
William Desportes
4cec0f1163 Stop pmadb database detection when all features are disabled 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-04-08 13:42:44 +02:00
William Desportes
24ac923632 Fix Internal error in ./libraries/classes/Controllers/HomeController.php#314 
TypeError: mb_strlen(): Argument #1 ($string) must be of type string, bool given

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-22 12:47:59 +01:00
William Desportes
883226c1f7 Ref #17478 - Fix mistake in PHP operators 
Ref: 630f9bf00e
Thank you @MoonE !

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-21 16:37:44 +01:00
William Desportes
630f9bf00e Ref #17478 - Fix PHP Undefined array key "auth_type" when server does not start at 0 
```
Internal error in ./libraries/classes/Controllers/HomeController.php#235
 ErrorException: Undefined array key "auth_type"
```

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 23:02:50 +01:00
Maurício Meneghini Fauth
5d9142674d Allow longer cookie encryption keys to be used 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:34:18 -03:00
Maurício Meneghini Fauth
0ed04a6c00 Remove trigger_error calls from HomeController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
(cherry picked from commit c5611531c0)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:33:38 -03:00
Andrija Vučinić
c6bb867787 Revert to old behavior for ShowServerInfo 
Seems we changed the flag behavior here: cd1b8a9b77 (diff-bb8d8aecc2e174245e8b95be9344176aba8971d024f3b2c2311b8e58ddd59b31L149)

I'm not sure whether that was intentional, but it causes the `Database server` panel to always show compared to pre 5.2.0.

Truth be told, it doesn't make sense to have that flag and then the additional checks in the block when we know it's `true`, so I updated the code to take care of that.

Signed-off-by: Andrija Vučinić <andrija.vucinic@gmail.com>
 2022-05-11 22:57:55 +02:00
Maurício Meneghini Fauth
411bacf613 Use Sodium for auth cookies encryption 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 18:46:04 -03:00
Maurício Meneghini Fauth
c411121fd8 Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c4575fd48b Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Kamil Tekiela
945d887a10 Fix var annotation for Charset and Collation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-09 22:25:58 +00:00
Maurício Meneghini Fauth
b2a51c4d84 Create the RelationParameters value object 
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
3e0856c77b Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
3531775b7c Add type declarations to the controllers contructors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-11 17:32:22 -03:00
Maurício Meneghini Fauth
9adce40034 Extract controllers from HomeController 
Extracts CollationConnectionController, GitInfoController and
RecentTablesListController controllers from HomeController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-05 00:40:18 -03:00
Maurício Meneghini Fauth
2de0a7cbd7 Update Psalm baseline 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-28 12:11:52 -03:00
Maurício Meneghini Fauth
9adaa912e1 Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
1c084de30b Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
cd1b8a9b77 Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-22 15:14:24 -03:00
William Desportes
77b5e402c5 Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-05-11 01:20:20 +02:00
William Desportes
ef758ae43d Merge #16855 - Replace secure.php.net with www.php.net and remove Polish and Persian 
Pull-request: #16855

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-05-10 23:30:25 +02:00
William Desportes
9487604a42 Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-28 02:12:17 +02:00
William Desportes
34f8295b94 Fix #16854 - Undefined index: SERVER_SOFTWARE 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-27 23:57:30 +02:00
Liviu-Mihail Concioiu
1c8f9b4d23 Replace secure.php.net with www.php.net and remove Polish and Persian from PHP documentation 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2021-04-26 14:32:03 +02:00
Maurício Meneghini Fauth
f19a3d95c4 Remove LanguageManager::getSelectorDisplay method 
Redesign the language selector to use Bootstrap style.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-22 15:51:26 -03:00
William Desportes
187ef65d26 Extract some logic from HomeController::checkRequirements into smaller functions 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 22:27:58 +02:00
Maurício Meneghini Fauth
7ba3e3db9e Fix possible null arg when creating a new Git object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-25 14:18:45 -03:00
Maurício Meneghini Fauth
91bd0df2e5 Rename $err_url global to $errorUrl 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-24 19:39:28 -03:00
William Desportes
84ede575e3 Remove dependency on Config class of Git class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-24 18:29:52 +01:00
Maurício Meneghini Fauth
33d711215d Remove the PMA_VERSION constant 
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 22:22:55 -03:00
William Desportes
b5263d44c8 Replace PMA_MAJOR_VERSION by Version::SERIES 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-05 21:22:42 +01:00
Maurício Meneghini Fauth
d83abf63e7 Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
12d662baa3 Replace themes preview popup with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-02-04 23:21:31 -03:00
Maurício Meneghini Fauth
17a01d9d9d Extract the HTML from ThemeManager::getHtmlSelectBox 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-28 22:34:01 -03:00
William Desportes
2141d81e7e Fix #16520 - $cfg['ShowDatabasesNavigationAsTree'] = false; on select not working 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-12-07 14:35:05 +01:00
Maurício Meneghini Fauth
6b81080127 Remove Common::server method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
e6ec9df84e Remove DBI dep from Controllers/AbstractController 
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-11 22:48:44 -03:00
Maurício Meneghini Fauth
461cc87521 Remove list templates 
- templates/list/item.twig
- templates/list/unordered.twig

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-12 20:43:55 -03:00
Maurício Meneghini Fauth
4821b45ef8 Return commit info in Git::checkGitRevision method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-30 03:23:08 -03:00
Maurício Meneghini Fauth
7486e99568 Extract HTML from Git::getHtml method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-30 01:33:34 -03:00
Maurício Meneghini Fauth
65c93872f0 Remove Display\GitRevision class 
Move display method to Git class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-29 22:50:49 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00