webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-25 06:39:48 +03:00
Code Activity
128,289 Commits 12 Branches 481 Tags
QA_5_2
Commit Graph

42 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
86fb10e688 Fix coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
 2026-07-31 13:32:49 -03:00
Maurício Meneghini Fauth
4742c1f985 Add PHPUnit attributes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
 2026-07-30 17:57:54 -03:00
Towy
8fea06d16b Fix #18304 - Avoid TypeError when adding a column without index data 
CreateAddField::getIndexedColumns() passed the raw $_POST index values
straight to json_decode(). When a column is added through a request that
does not submit the primary_indexes, indexes, unique_indexes,
fulltext_indexes and spatial_indexes fields (for example when adding a
primary key column from the normalization page), those keys are
undefined. Under strict_types this raised "json_decode(): Argument #1
($json) must be of type string, null given" together with "Undefined
array key" warnings, and the column was not added.

Default each of these request values to an empty JSON array so that
adding a column keeps working when no index information is provided.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Towy <towy@airreps.link>
 2026-07-09 18:34:22 +02:00
Maurício Meneghini Fauth
555ea56cbd Make PHPUnit's assertions stricter 
Backports #18993 to QA_5_2.

This makes merging QA_5_2 into master easier.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-10-12 15:33:45 -03:00
Maurício Meneghini Fauth
7fc96d6621 Call PHPUnit static methods using static calls 
Backports #18907 to QA_5_2.

This makes merging QA_5_2 into master easier.
Changes done using Rector.

- #18907

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-10-12 14:28:22 -03:00
Maurício Meneghini Fauth
46f2c8871c Backport some fixes for PHPUnit 10 compatibility 
- Fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1070623

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-08-13 20:13:18 -03:00
Kamil Tekiela
e0e3748723 Fix ENGINE escaping 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-13 11:58:15 +00:00
Kamil Tekiela
5b471e7c64 Redesign CreateAddField::setColumnCreationStatementSuffix() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-08 22:24:49 +00:00
Kamil Tekiela
ce820ed522 Redesign CreateAddField::getColumnCreationStatements() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-08 18:27:26 +00:00
Maurício Meneghini Fauth
f00d70cccb Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
f3b79d83c0 Add PHPUnit's Covers annotation on test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
3d539b78e6 Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-27 16:07:09 -03:00
William Desportes
58d760b213 Cover most of the code of CreateAddField 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-12 00:38:00 +01:00
William Desportes
1d429c5ed9 Add a test for CreateAddField::getColumnCreationQuery 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-11 21:09:46 +01:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
William Desportes
0340f66740 Fix some tests having wrong typehints 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-17 23:55:49 +02:00
William Desportes
a80153a633 Add typehints using phpcbf on test/* 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-17 22:52:42 +02:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
0b9c35a056 Remove uses statements from the same namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-24 13:00:24 -03:00
William Desportes
f89f4c9f2c Fix failing tests after tear down cleans everything 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 13:19:23 +02:00
William Desportes
8f7d3d1fa7 Fix test cases after backupGlobals = false 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805 Call parent's setUp and tearDown 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901 Use AbstractTestCase on all unit tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:15:06 +02:00
William Desportes
81a2504780 Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-03-19 23:41:17 +01:00
William Desportes
f6af795eb3 Add test case for #15898 
Depends on 20e3d2fa9f

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-28 23:12:31 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
23c3579804 Format array declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors 
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8' 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-12 21:04:19 -02:00
Madhura Jayaratne
d6e04ca09b Fix #249 CSRF to CREATE TABLE query 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2018-11-10 20:48:58 -02:00
Maurício Meneghini Fauth
dc8c92bfd8 Enable strict mode in test files 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
79ab4f4a50 Use DI for DatabaseInterface instance 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-15 15:04:37 -02:00
Maurício Meneghini Fauth
a1e088d5f8 Fix coding style issues 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-15 14:12:43 -02:00
Maurício Meneghini Fauth
dc04987a68 Replace static methods with instance methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-15 12:31:04 -02:00
Maurício Meneghini Fauth
7efdc53d2a Fix 'count parameter must be an array' error 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 16:07:37 -02:00
Maurício Meneghini Fauth
e7900a82cb Add CreateAddFieldTest 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 14:05:08 -02:00