webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-28 07:41:55 +03:00
Code Activity
124,532 Commits 12 Branches 481 Tags
QA_5_1
Commit Graph

114 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
02e8588404 Merge branch 'QA_4_9-security' into QA_5_1-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-10 18:39:23 -03:00
William Desportes
dc5cf4766b Fix #16906 - Escape the table name that is checked with backquotes on canAccessStorageTable function 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-28 04:06:18 +02:00
William Desportes
b0ec0fd112 Fix #16906 - Replace table names with the configuration ones while creating the storage tables 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-28 03:55:58 +02:00
William Desportes
576decd1f4 Fix coding standard issues 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-28 01:46:45 +02:00
William Desportes
c01e681c33 Prevent overriding user setting while auto fixing pma storage 
Once the table was created it was overriding the setting. It should respect that the user said the table will be named pma__userconfig_table and not pma__userconfig (the default value).
If the database had the default tables in it, the detection would silently mark them as the right tables totally ignoring the user defined settings for the table names.

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-28 00:05:07 +02:00
William Desportes
b527b13e2d Old typo fix 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-27 23:23:22 +02:00
William Desportes
bb2c869e4c Ref #16906 - Clear the relation cache after the control db was created 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-27 23:10:50 +02:00
William Desportes
9c0dcc2043 Fix #16906 - Use the control connection to create the storage database and tables 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-27 23:09:16 +02:00
William Desportes
2ea46aa113 Ref #16906 - Return an error message if the pma storage db could not be selected 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-27 22:32:56 +02:00
William Desportes
cdb027c119 Ref #16906 - Allow to create the pma storage db using a different name than "phpmyadmin" 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-27 17:06:45 +02:00
William Desportes
0de25bebd4 Fix #16995 - Edit binary foreign key adds a 1 on the selected value 
Caused-by: e9d3fdd493

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-28 18:48:59 +02:00
William Desportes
6529d81b71 Fix "Notice: Undefined index: foreign_keys_data" 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-27 15:46:57 +02:00
William Desportes
eb258a806d Query adjustments 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-24 16:19:53 +02:00
Maurício Meneghini Fauth
c64b77abe1 Move HTML's table CSS to the pma-table class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-16 16:36:16 -03:00
William Desportes
5abcae9255 Fixed some typos in the code base 
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
e7c8e20edb Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-02 00:37:23 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
461cc87521 Remove list templates 
- templates/list/item.twig
- templates/list/unordered.twig

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-12 20:43:55 -03:00
Maurício Meneghini Fauth
e5514a6b66 Fix some PHPStan errors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-10 21:24:35 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
e81146e4b3 Remove useless return annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-07 10:30:27 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors 
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-02 16:12:07 -03:00
Maurício Meneghini Fauth
58eee2e371 Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 21:46:12 -03:00
Maurício Meneghini Fauth
199e3d9813 Fix coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 21:08:55 -03:00
William Desportes
1dd98ba696 Trim down Relation::checkTableAccess 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-27 21:03:44 +02:00
William Desportes
c86f90dffa Split some code in Relation class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-27 19:20:53 +02:00
William Desportes
aba5e27a82 Some code fixes and improvements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-27 18:55:58 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
8dd310fb6a Remove assignments in if conditions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 01:35:19 -03:00
Maurício Meneghini Fauth
84139f4d51 Remove some useless variables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 16:15:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
e1c69c6a14 Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-22 00:26:45 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues 
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-19 22:29:54 -03:00
William Desportes
249ee4dbd2 Improve JS and phpdoc by removing useless spaces 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-16 18:39:42 +01:00
William Desportes
9799dfc643 Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-29 15:46:26 +01:00
William Desportes
de652cd95a Add some typecasts to fix #15719 and other possible issues 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-29 15:39:04 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567) 
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-21 20:20:05 -03:00
William Desportes
eda044cbac Improve code after Scrutinizer report 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-11 21:33:25 +01:00
William Desportes
7f0949ad00 Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-11 20:54:26 +01:00
William Desportes
5a83a289d8 Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-11 20:31:34 +01:00
William Desportes
e070256fe4 Fix #13912 and #15123 - Tables of phpMyAdmin storage are not accessible 
Fixes: #13912
Fixes: #15123

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-11 12:02:54 +01:00