diff --git a/libraries/controllers/server/ServerBinlogController.php b/libraries/controllers/server/ServerBinlogController.php index 3054ad29e8..893846e17c 100644 --- a/libraries/controllers/server/ServerBinlogController.php +++ b/libraries/controllers/server/ServerBinlogController.php @@ -13,6 +13,7 @@ use PMA\libraries\controllers\Controller; use PMA\libraries\DatabaseInterface; use PMA\libraries\Message; use PMA\libraries\Util; +use PMA\libraries\Template; /** * Handles viewing binary logs @@ -21,25 +22,25 @@ use PMA\libraries\Util; */ class ServerBinlogController extends Controller { - /** - * array binary log files - */ - protected $binary_logs; + /** + * array binary log files + */ + protected $binary_logs; - /** - * Constructs ServerBinlogController - */ - public function __construct() - { - parent::__construct(); - $this->binary_logs = $this->dbi->fetchResult( + /** + * Constructs ServerBinlogController + */ + public function __construct() + { + parent::__construct(); + $this->binary_logs = $this->dbi->fetchResult( 'SHOW MASTER LOGS', 'Log_name', null, null, DatabaseInterface::QUERY_STORE ); - } + } /** * Index action @@ -80,48 +81,12 @@ class ServerBinlogController extends Controller */ private function _getLogSelector($url_params) { - $html = ""; - if (count($this->binary_logs) > 1) { - $html .= '
'; - } - - return $html; + return Template::get('server/binlog/log_selector')->render( + array( + 'url_params' => $url_params, + 'binary_logs' => $this->binary_logs, + ) + ); } /** diff --git a/templates/server/binlog/log_selector.phtml b/templates/server/binlog/log_selector.phtml new file mode 100644 index 0000000000..c3ab733272 --- /dev/null +++ b/templates/server/binlog/log_selector.phtml @@ -0,0 +1,28 @@ + \ No newline at end of file