mirror of
https://github.com/BookStackApp/BookStack.git
synced 2025-10-22 07:52:19 +03:00
As per PR #5800 * DB: Planned out new entity table format via migrations * DB: Created entity migration logic Made some other tweaks/fixes while testing. * DB: Added change of entity relation columns to suit new entities table * DB: Got most view queries working for new structure * Entities: Started logic change to new structure Updated base entity class, and worked through BaseRepo. Need to go through other repos next. Removed a couple of redundant interfaces as part of this since we can move the logic onto the shared ContainerData model as needed. * Entities: Been through repos to update for new format * Entities: Updated repos to act on refreshed clones Changes to core entity models are now done on clones to ensure clean state before save, and those clones are returned back if changes are needed after that action. * Entities: Updated model classes & relations for changes * Entities: Changed from *Data to a common "contents" system Added smart loading from builder instances which should hydrate with "contents()" loaded via join, while keeping the core model original. * Entities: Moved entity description/covers to own non-model classes Added back some interfaces. * Entities: Removed use of contents system for data access * Entities: Got most queries back to working order * Entities: Reverted back to data from contents, fixed various issues * Entities: Started addressing issues from tests * Entities: Addressed further tests/issues * Entities: Been through tests to get all passing in dev Fixed issues and needed test changes along the way. * Entities: Addressed phpstan errors * Entities: Reviewed TODO notes * Entities: Ensured book/shelf relation data removed on destroy * Entities: Been through API responses & adjusted field visibility * Entities: Added type index to massively improve query speed
218 lines
8.5 KiB
PHP
218 lines
8.5 KiB
PHP
<?php
|
|
|
|
namespace Tests\Auth;
|
|
|
|
use BookStack\Access\Mfa\MfaValue;
|
|
use BookStack\Activity\ActivityType;
|
|
use BookStack\Users\Models\Role;
|
|
use BookStack\Users\Models\User;
|
|
use Illuminate\Support\Facades\Hash;
|
|
use PragmaRX\Google2FA\Google2FA;
|
|
use Tests\TestCase;
|
|
|
|
class MfaConfigurationTest extends TestCase
|
|
{
|
|
public function test_totp_setup()
|
|
{
|
|
$editor = $this->users->editor();
|
|
$this->assertDatabaseMissing('mfa_values', ['user_id' => $editor->id]);
|
|
|
|
// Setup page state
|
|
$resp = $this->actingAs($editor)->get('/mfa/setup');
|
|
$this->withHtml($resp)->assertElementContains('a[href$="/mfa/totp/generate"]', 'Setup');
|
|
|
|
// Generate page access
|
|
$resp = $this->get('/mfa/totp/generate');
|
|
$resp->assertSee('Mobile App Setup');
|
|
$resp->assertSee('Verify Setup');
|
|
$this->withHtml($resp)->assertElementExists('form[action$="/mfa/totp/confirm"] button');
|
|
$this->assertSessionHas('mfa-setup-totp-secret');
|
|
$svg = $this->withHtml($resp)->getOuterHtml('#main-content .card svg');
|
|
|
|
// Validation error, code should remain the same
|
|
$resp = $this->post('/mfa/totp/confirm', [
|
|
'code' => 'abc123',
|
|
]);
|
|
$resp->assertRedirect('/mfa/totp/generate');
|
|
$resp = $this->followRedirects($resp);
|
|
$resp->assertSee('The provided code is not valid or has expired.');
|
|
$revisitSvg = $this->withHtml($resp)->getOuterHtml('#main-content .card svg');
|
|
$this->assertTrue($svg === $revisitSvg);
|
|
$secret = decrypt(session()->get('mfa-setup-totp-secret'));
|
|
|
|
$resp->assertSee("?secret={$secret}&issuer=BookStack&algorithm=SHA1&digits=6&period=30");
|
|
|
|
// Successful confirmation
|
|
$google2fa = new Google2FA();
|
|
$otp = $google2fa->getCurrentOtp($secret);
|
|
$resp = $this->post('/mfa/totp/confirm', [
|
|
'code' => $otp,
|
|
]);
|
|
$resp->assertRedirect('/mfa/setup');
|
|
|
|
// Confirmation of setup
|
|
$resp = $this->followRedirects($resp);
|
|
$resp->assertSee('Multi-factor method successfully configured');
|
|
$this->withHtml($resp)->assertElementContains('a[href$="/mfa/totp/generate"]', 'Reconfigure');
|
|
|
|
$this->assertDatabaseHas('mfa_values', [
|
|
'user_id' => $editor->id,
|
|
'method' => 'totp',
|
|
]);
|
|
$this->assertFalse(session()->has('mfa-setup-totp-secret'));
|
|
$value = MfaValue::query()->where('user_id', '=', $editor->id)
|
|
->where('method', '=', 'totp')->first();
|
|
$this->assertEquals($secret, decrypt($value->value));
|
|
}
|
|
|
|
public function test_backup_codes_setup()
|
|
{
|
|
$editor = $this->users->editor();
|
|
$this->assertDatabaseMissing('mfa_values', ['user_id' => $editor->id]);
|
|
|
|
// Setup page state
|
|
$resp = $this->actingAs($editor)->get('/mfa/setup');
|
|
$this->withHtml($resp)->assertElementContains('a[href$="/mfa/backup_codes/generate"]', 'Setup');
|
|
|
|
// Generate page access
|
|
$resp = $this->get('/mfa/backup_codes/generate');
|
|
$resp->assertSee('Backup Codes');
|
|
$this->withHtml($resp)->assertElementContains('form[action$="/mfa/backup_codes/confirm"]', 'Confirm and Enable');
|
|
$this->assertSessionHas('mfa-setup-backup-codes');
|
|
$codes = decrypt(session()->get('mfa-setup-backup-codes'));
|
|
// Check code format
|
|
$this->assertCount(16, $codes);
|
|
$this->assertEquals(16 * 11, strlen(implode('', $codes)));
|
|
// Check download link
|
|
$resp->assertSee(base64_encode(implode("\n\n", $codes)));
|
|
|
|
// Confirm submit
|
|
$resp = $this->post('/mfa/backup_codes/confirm');
|
|
$resp->assertRedirect('/mfa/setup');
|
|
|
|
// Confirmation of setup
|
|
$resp = $this->followRedirects($resp);
|
|
$resp->assertSee('Multi-factor method successfully configured');
|
|
$this->withHtml($resp)->assertElementContains('a[href$="/mfa/backup_codes/generate"]', 'Reconfigure');
|
|
|
|
$this->assertDatabaseHas('mfa_values', [
|
|
'user_id' => $editor->id,
|
|
'method' => 'backup_codes',
|
|
]);
|
|
$this->assertFalse(session()->has('mfa-setup-backup-codes'));
|
|
$value = MfaValue::query()->where('user_id', '=', $editor->id)
|
|
->where('method', '=', 'backup_codes')->first();
|
|
$this->assertEquals($codes, json_decode(decrypt($value->value)));
|
|
}
|
|
|
|
public function test_backup_codes_cannot_be_confirmed_if_not_previously_generated()
|
|
{
|
|
$resp = $this->asEditor()->post('/mfa/backup_codes/confirm');
|
|
$resp->assertStatus(500);
|
|
}
|
|
|
|
public function test_mfa_method_count_is_visible_on_user_edit_page()
|
|
{
|
|
$user = $this->users->editor();
|
|
$resp = $this->actingAs($this->users->admin())->get($user->getEditUrl());
|
|
$resp->assertSee('0 methods configured');
|
|
|
|
MfaValue::upsertWithValue($user, MfaValue::METHOD_TOTP, 'test');
|
|
$resp = $this->get($user->getEditUrl());
|
|
$resp->assertSee('1 method configured');
|
|
|
|
MfaValue::upsertWithValue($user, MfaValue::METHOD_BACKUP_CODES, 'test');
|
|
$resp = $this->get($user->getEditUrl());
|
|
$resp->assertSee('2 methods configured');
|
|
}
|
|
|
|
public function test_mfa_setup_link_only_shown_when_viewing_own_user_edit_page()
|
|
{
|
|
$admin = $this->users->admin();
|
|
$resp = $this->actingAs($admin)->get($admin->getEditUrl());
|
|
$this->withHtml($resp)->assertElementExists('a[href$="/mfa/setup"]');
|
|
|
|
$resp = $this->actingAs($admin)->get($this->users->editor()->getEditUrl());
|
|
$this->withHtml($resp)->assertElementNotExists('a[href$="/mfa/setup"]');
|
|
}
|
|
|
|
public function test_mfa_indicator_shows_in_user_list()
|
|
{
|
|
$admin = $this->users->admin();
|
|
User::query()->where('id', '!=', $admin->id)->delete();
|
|
|
|
$resp = $this->actingAs($admin)->get('/settings/users');
|
|
$this->withHtml($resp)->assertElementNotExists('[title="MFA Configured"] svg');
|
|
|
|
MfaValue::upsertWithValue($admin, MfaValue::METHOD_TOTP, 'test');
|
|
$resp = $this->actingAs($admin)->get('/settings/users');
|
|
$this->withHtml($resp)->assertElementExists('[title="MFA Configured"] svg');
|
|
}
|
|
|
|
public function test_remove_mfa_method()
|
|
{
|
|
$admin = $this->users->admin();
|
|
|
|
MfaValue::upsertWithValue($admin, MfaValue::METHOD_TOTP, 'test');
|
|
$this->assertEquals(1, $admin->mfaValues()->count());
|
|
$resp = $this->actingAs($admin)->get('/mfa/setup');
|
|
$this->withHtml($resp)->assertElementExists('form[action$="/mfa/totp/remove"]');
|
|
|
|
$resp = $this->delete('/mfa/totp/remove');
|
|
$resp->assertRedirect('/mfa/setup');
|
|
$resp = $this->followRedirects($resp);
|
|
$resp->assertSee('Multi-factor method successfully removed');
|
|
|
|
$this->assertActivityExists(ActivityType::MFA_REMOVE_METHOD);
|
|
$this->assertEquals(0, $admin->mfaValues()->count());
|
|
}
|
|
|
|
public function test_mfa_required_if_set_on_role()
|
|
{
|
|
$user = $this->users->viewer();
|
|
$user->password = Hash::make('password');
|
|
$user->save();
|
|
/** @var Role $role */
|
|
$role = $user->roles()->first();
|
|
$role->mfa_enforced = true;
|
|
$role->save();
|
|
|
|
$resp = $this->post('/login', ['email' => $user->email, 'password' => 'password']);
|
|
$this->assertFalse(auth()->check());
|
|
$resp->assertRedirect('/mfa/verify');
|
|
}
|
|
|
|
public function test_mfa_required_if_mfa_option_configured()
|
|
{
|
|
$user = $this->users->viewer();
|
|
$user->password = Hash::make('password');
|
|
$user->save();
|
|
$user->mfaValues()->create([
|
|
'method' => MfaValue::METHOD_TOTP,
|
|
'value' => 'test',
|
|
]);
|
|
|
|
$resp = $this->post('/login', ['email' => $user->email, 'password' => 'password']);
|
|
$this->assertFalse(auth()->check());
|
|
$resp->assertRedirect('/mfa/verify');
|
|
}
|
|
|
|
public function test_totp_setup_url_shows_correct_user_when_setup_forced_upon_login()
|
|
{
|
|
$admin = $this->users->admin();
|
|
/** @var Role $role */
|
|
$role = $admin->roles()->first();
|
|
$role->mfa_enforced = true;
|
|
$role->save();
|
|
|
|
$resp = $this->post('/login', ['email' => $admin->email, 'password' => 'password']);
|
|
$this->assertFalse(auth()->check());
|
|
$resp->assertRedirect('/mfa/verify');
|
|
|
|
$resp = $this->get('/mfa/totp/generate');
|
|
$resp->assertSeeText('Mobile App Setup');
|
|
$resp->assertDontSee('otpauth://totp/BookStack:guest%40example.com', false);
|
|
$resp->assertSee('otpauth://totp/BookStack:admin%40admin.com', false);
|
|
}
|
|
}
|