webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-30 04:23:11 +03:00
Code Activity

Centralised handling of permission form data to own class

Browse Source 
Also updates show roles on permission view to just those with
permissions applied.
Fixes rounded borders for lone permission rows.
Moves "Everyone Else" handling from role to new class.
This commit is contained in:
Dan Brown
2022-10-09 17:14:11 +01:00
parent bf591765c1
commit ffd6a1002e
6 changed files with 77 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
resources/sass/_components.scss
View File

@ -818,6 +818,9 @@ body.flexbox-support #entity-selector-wrap .popup-body .form-group {
border-radius: 0 0 4px 4px;
border-bottom-width: 1.5px;
}
.content-permissions-row:first-child:last-child {
border-radius: 4px;
}
.content-permissions-row-toggle-all {
visibility: hidden;
}

4
resources/views/form/entity-permissions.blade.php
View File

@ -19,13 +19,13 @@
@endif
<div class="content-permissions mt-m mb-xl">
@foreach(\BookStack\Auth\Role::restrictable() as $role)
@foreach($data->rolesWithPermissions() as $role)
@include('form.entity-permissions-row', ['role' => $role, 'model' => $model])
@endforeach
</div>
<div class="content-permissions mt-m mb-xl">
@include('form.entity-permissions-row', ['role' => \BookStack\Auth\Role::getEveryoneElseRole(), 'model' => $model])
@include('form.entity-permissions-row', ['role' => $data->everyoneElseRole(), 'model' => $model])
</div>
<div class="text-right">