webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-08-07 23:03:00 +03:00
Code Activity

404: Fixed entity list issue with entity with non-visible parent

Browse Source 
Adds our mixed entity list loader to popular queries for more efficient
loading.
This commit is contained in:
Dan Brown
2024-02-28 13:07:34 +00:00
parent 2009d4d6a8
commit f5f96f84e7
2 changed files with 36 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
tests/ErrorTest.php
View File

@@ -23,6 +23,35 @@ class ErrorTest extends TestCase
$notFound->assertSeeText('tester');
}
public function test_404_page_does_not_non_visible_content()
{
$editor = $this->users->editor();
$book = $this->entities->book();
$this->actingAs($editor)->get($book->getUrl())->assertOk();
$this->permissions->disableEntityInheritedPermissions($book);
$this->actingAs($editor)->get($book->getUrl())->assertNotFound();
}
public function test_404_page_shows_visible_content_within_non_visible_parent()
{
$editor = $this->users->editor();
$book = $this->entities->book();
$page = $book->pages()->first();
$this->actingAs($editor)->get($page->getUrl())->assertOk();
$this->permissions->disableEntityInheritedPermissions($book);
$this->permissions->addEntityPermission($page, ['view'], $editor->roles()->first());
$resp = $this->actingAs($editor)->get($book->getUrl());
$resp->assertNotFound();
$resp->assertSee($page->name);
$resp->assertDontSee($book->name);
}
public function test_item_not_found_does_not_get_logged_to_file()
{
$this->actingAs($this->users->viewer());