webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-28 17:02:04 +03:00
Code Activity

move zip export into exportservice

Browse Source
This commit is contained in:
Nikhil Jha
2020-05-13 20:07:19 -07:00
parent ea82c2f61b
commit e287d965f5
2 changed files with 26 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/Http/Controllers/BookExportController.php
View File

@ -6,7 +6,6 @@ use BookStack\Entities\Managers\BookContents;
use BookStack\Entities\ExportService;
use BookStack\Entities\Repos\BookRepo;
use Throwable;
use ZipArchive;
class BookExportController extends Controller
{
@ -72,20 +71,7 @@ class BookExportController extends Controller
public function zip(string $bookSlug)
{
$book = $this->bookRepo->getBySlug($bookSlug);
$z = new ZipArchive();
$z->open("book.zip", \ZipArchive::CREATE | \ZipArchive::OVERWRITE);
$bookTree = (new BookContents($book))->getTree(false, true);
foreach ($bookTree as $bookChild) {
if ($bookChild->isA('chapter')) {
$z->addEmptyDir($bookChild->name);
foreach ($bookChild->pages as $page) {
$z->addFromString($bookChild->name . "/" . $page->name . ".md", $this->exportService->pageToMarkdown($page));
}
} else {
$z->addFromString($bookChild->name . ".md", $this->exportService->pageToMarkdown($bookChild));
}
}
return response()->download('book.zip');
// TODO: Is not unlinking it a security issue?
$filename = $this->exportService->bookToZip($book);
return response()->download($filename);
}
}