webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-30 04:23:11 +03:00
Code Activity

Fixed settings redirect issue and custom head display

Browse Source 
- Fixed issue where redirect for `/settings` view would not be ran
  through base url generator so would not create a correct path in some
  cases. Now routed through controller with normal redirect.
- Fixed custom head content being active on settings pages due to route
  name changes, for when viewing settings, in last release.

Fixes #3356 and #3355
This commit is contained in:
Dan Brown
2022-03-30 19:15:24 +01:00
parent 135022136a
commit da4308bb0f
5 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/Settings/CustomHeadContentTest.php
View File

@ -26,7 +26,7 @@ class CustomHeadContentTest extends TestCase
public function test_configured_content_does_not_show_on_settings_page()
{
$this->setSettings(['app-custom-head' => '<script>console.log("cat");</script>']);
$resp = $this->asAdmin()->get('/settings');
$resp = $this->asAdmin()->get('/settings/features');
$resp->assertDontSee('console.log("cat")', false);
}