1
0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-08-06 12:02:45 +03:00

Made a bunch of tinymce 6 upgrade fixes

- Added workaround for new 'srcdoc' usage that's breaking content in
  Firefox, added new 'custom-changes.md' file to document for future.
- Updated old usages of 'new' when creating nodes.
- Tested and changed logic, where required, where 'editor.dom.select'
  has been used to replace the old '$' usages.
- Fixed bad boolean value being passed to 'setActive' in task list
  logic.
This commit is contained in:
Dan Brown
2022-07-18 13:18:46 +01:00
parent c519f707e8
commit cd929b2555
8 changed files with 33 additions and 17 deletions

View File

@@ -0,0 +1,17 @@
### Srcdoc usage
By default, as of tiny 6, the editor would use srcdoc which prevents cookies being sent with images in Firefox as
it's considered cross origin. This removes that usage to work around this case:
[Relevant TinyMCE issue](https://github.com/tinymce/tinymce/issues/7746).
Source code change applied:
```javascript
// Find:
t.srcdoc=e.iframeHTML
// Replace:
t.contentDocument.open();t.contentDocument.write(e.iframeHTML);t.contentDocument.close();
```

File diff suppressed because one or more lines are too long