webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-28 17:02:04 +03:00
Code Activity

Added test for logical-theme-system command registration

Browse Source 
Changed how the command registration was handled due to complications of
action order found during testing. Now the theme service will resolve
and directly register the command on the Kernel instead of them being
fetched from the ThemeService from within Kernel.
More direct, Seems to work.
This commit is contained in:
Dan Brown
2021-11-22 19:03:04 +00:00
parent cdaad2f40e
commit cb30c258df
3 changed files with 23 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/Console/Kernel.php
View File

@ -2,11 +2,8 @@
namespace BookStack\Console;
use BookStack\Facades\Theme;
use BookStack\Theming\ThemeService;
use Illuminate\Console\Scheduling\Schedule;
use Illuminate\Foundation\Console\Kernel as ConsoleKernel;
use Symfony\Component\Console\Command\Command;
class Kernel extends ConsoleKernel
{
@ -38,13 +35,6 @@ class Kernel extends ConsoleKernel
*/
protected function commands()
{
// Default framework command loading from 'Commands' directory
$this->load(__DIR__ . '/Commands');
// Load any user commands that have been registered via the theme system.
$themeService = $this->app->make(ThemeService::class);
foreach ($themeService->getRegisteredCommands() as $command) {
$this->registerCommand($command);
}
}
}