webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-30 04:23:11 +03:00
Code Activity

Updated attachments to not be saved with a complete extension

Browse Source 
Intended to limit impact in the event the storage path is potentially
exposed.
This commit is contained in:
Dan Brown
2021-11-01 11:32:00 +00:00
parent 4360da03d4
commit bfbccbede1
4 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/Uploads/AttachmentTest.php
View File

@ -109,7 +109,8 @@ class AttachmentTest extends TestCase
$attachment = Attachment::query()->orderBy('id', 'desc')->first();
$this->assertStringNotContainsString($fileName, $attachment->path);
$this->assertStringEndsWith('.txt', $attachment->path);
$this->assertStringEndsWith('-txt', $attachment->path);
$this->deleteUploads();
}
public function test_file_display_and_access()