webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-06-11 13:48:13 +03:00
Code Activity

Replaced el.components mapping with component service weakmap

Browse Source 
Old system was hard to track in terms of usage and it's application of
'components' properties directly to elements was shoddy.
This routes usage via the components service, with element-specific
component usage tracked via a local weakmap.
Updated existing found usages to use the new system.
This commit is contained in:
Dan Brown
2022-11-16 15:46:41 +00:00
parent 25c23a2e5f
commit be736b3939
9 changed files with 81 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
resources/js/components/code-editor.js
View File

@ -126,7 +126,7 @@ export class CodeEditor extends Component {
}
this.loadHistory();
this.popup.components.popup.show(() => {
this.getPopup().show(() => {
Code.updateLayout(this.editor);
this.editor.focus();
}, () => {
@ -135,10 +135,17 @@ export class CodeEditor extends Component {
}
hide() {
this.popup.components.popup.hide();
this.getPopup().hide();
this.addHistory();
}
/**
* @returns {Popup}
*/
getPopup() {
return window.$components.firstOnElement(this.popup, 'popup');
}
async updateEditorMode(language) {
const Code = await window.importVersioned('code');
Code.setMode(this.editor, language, this.editor.getValue());