webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-30 04:23:11 +03:00
Code Activity

OIDC: Added testing coverage for picture fetching

Browse Source
This commit is contained in:
Dan Brown
2025-05-24 14:36:36 +01:00
parent f9dbbe5d70
commit b64c9b31d5
6 changed files with 64 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Access/Oidc/OidcService.php
View File

@ -222,6 +222,8 @@ class OidcService
throw new OidcException($exception->getMessage());
}
// TODO - Update this (and tests and config option comments) to actually align with LDAP system
// which syncs whenever on login or registration, where there's no existing avatar.
if ($this->config()['fetch_avatar'] && $user->wasRecentlyCreated && $userDetails->picture) {
$this->userAvatars->assignToUserFromUrl($user, $userDetails->picture);
}

2
app/Uploads/UserAvatars.php
View File

@ -65,7 +65,7 @@ class UserAvatars
$mime = (new WebSafeMimeSniffer())->sniff($imageData);
[$format, $type] = explode('/', $mime, 2);
if ($format !== 'image' || ImageService::isExtensionSupported($type)) {
if ($format !== 'image' || !ImageService::isExtensionSupported($type)) {
return;
}

1
app/Users/Models/User.php
View File

@ -45,6 +45,7 @@ use Illuminate\Support\Collection;
* @property string $system_name
* @property Collection $roles
* @property Collection $mfaValues
* @property ?Image $avatar
*/
class User extends Model implements AuthenticatableContract, CanResetPasswordContract, Loggable, Sluggable
{