webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-30 04:23:11 +03:00
Code Activity

Removed joint_permissions auto_increment id

Browse Source 
Removed auto_incrementing id and set a primary key of the [role_id,
entity_type, entity_id, action] instead since this table could recieve a
lot of activity, especially when permission regeneration was automated,
leading to very high auto_increment counts which could max out the
integer limit.

Also updated some RolesTest comment endpoints to align with
recent route changes.

Should fix #2091
This commit is contained in:
Dan Brown
2020-08-04 13:02:31 +01:00
parent 7590ecd37c
commit a9f02550f0
3 changed files with 45 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/Permissions/RolesTest.php
View File

@ -2,10 +2,8 @@
use BookStack\Entities\Bookshelf;
use BookStack\Entities\Page;
use BookStack\Auth\Permissions\PermissionsRepo;
use BookStack\Auth\Role;
use Laravel\BrowserKitTesting\HttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Tests\BrowserKitTest;
class RolesTest extends BrowserKitTest
@ -852,7 +850,7 @@ class RolesTest extends BrowserKitTest
private function addComment($page) {
$comment = factory(\BookStack\Actions\Comment::class)->make();
$url = "/ajax/page/$page->id/comment";
$url = "/comment/$page->id";
$request = [
'text' => $comment->text,
'html' => $comment->html
@ -865,7 +863,7 @@ class RolesTest extends BrowserKitTest
private function updateComment($commentId) {
$comment = factory(\BookStack\Actions\Comment::class)->make();
$url = "/ajax/comment/$commentId";
$url = "/comment/$commentId";
$request = [
'text' => $comment->text,
'html' => $comment->html
@ -875,7 +873,7 @@ class RolesTest extends BrowserKitTest
}
private function deleteComment($commentId) {
$url = '/ajax/comment/' . $commentId;
$url = '/comment/' . $commentId;
return $this->json('DELETE', $url);
}