webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-28 17:02:04 +03:00
Code Activity

Added web-middleware based theme events

Browse Source
This commit is contained in:
Dan Brown
2021-03-17 12:56:56 +00:00
parent a5d2a26fcc
commit 9d37af9453
4 changed files with 120 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

73
tests/ThemeTest.php
View File

@ -5,6 +5,8 @@ use BookStack\Entities\Tools\PageContent;
use BookStack\Facades\Theme;
use BookStack\Theming\ThemeEvents;
use File;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use League\CommonMark\ConfigurableEnvironmentInterface;
class ThemeTest extends TestCase
@ -14,7 +16,7 @@ class ThemeTest extends TestCase
public function test_translation_text_can_be_overridden_via_theme()
{
$this->usingThemeFolder(function() {
$this->usingThemeFolder(function () {
$translationPath = theme_path('/lang/en');
File::makeDirectory($translationPath, 0777, true);
@ -30,11 +32,11 @@ class ThemeTest extends TestCase
public function test_theme_functions_file_used_and_app_boot_event_runs()
{
$this->usingThemeFolder(function($themeFolder) {
$this->usingThemeFolder(function ($themeFolder) {
$functionsFile = theme_path('functions.php');
app()->alias('cat', 'dog');
file_put_contents($functionsFile, "<?php\nTheme::listen(\BookStack\Theming\ThemeEvents::APP_BOOT, function(\$app) { \$app->alias('cat', 'dog');});");
$this->runWithEnv('APP_THEME', $themeFolder, function() {
$this->runWithEnv('APP_THEME', $themeFolder, function () {
$this->assertEquals('cat', $this->app->getAlias('dog'));
});
});
@ -43,7 +45,7 @@ class ThemeTest extends TestCase
public function test_event_commonmark_environment_configure()
{
$callbackCalled = false;
$callback = function($environment) use (&$callbackCalled) {
$callback = function ($environment) use (&$callbackCalled) {
$this->assertInstanceOf(ConfigurableEnvironmentInterface::class, $environment);
$callbackCalled = true;
return $environment;
@ -57,6 +59,69 @@ class ThemeTest extends TestCase
$this->assertTrue($callbackCalled);
}
public function test_event_web_middleware_before()
{
$callbackCalled = false;
$requestParam = null;
$callback = function ($request) use (&$callbackCalled, &$requestParam) {
$requestParam = $request;
$callbackCalled = true;
};
Theme::listen(ThemeEvents::WEB_MIDDLEWARE_BEFORE, $callback);
$this->get('/login', ['Donkey' => 'cat']);
$this->assertTrue($callbackCalled);
$this->assertInstanceOf(Request::class, $requestParam);
$this->assertEquals('cat', $requestParam->header('donkey'));
}
public function test_event_web_middleware_before_return_val_used_as_response()
{
$callback = function (Request $request) {
return response('cat', 412);
};
Theme::listen(ThemeEvents::WEB_MIDDLEWARE_BEFORE, $callback);
$resp = $this->get('/login', ['Donkey' => 'cat']);
$resp->assertSee('cat');
$resp->assertStatus(412);
}
public function test_event_web_middleware_after()
{
$callbackCalled = false;
$requestParam = null;
$responseParam = null;
$callback = function ($request, Response $response) use (&$callbackCalled, &$requestParam, &$responseParam) {
$requestParam = $request;
$responseParam = $response;
$callbackCalled = true;
$response->header('donkey', 'cat123');
};
Theme::listen(ThemeEvents::WEB_MIDDLEWARE_AFTER, $callback);
$resp = $this->get('/login', ['Donkey' => 'cat']);
$this->assertTrue($callbackCalled);
$this->assertInstanceOf(Request::class, $requestParam);
$this->assertInstanceOf(Response::class, $responseParam);
$resp->assertHeader('donkey', 'cat123');
}
public function test_event_web_middleware_after_return_val_used_as_response()
{
$callback = function () {
return response('cat456', 443);
};
Theme::listen(ThemeEvents::WEB_MIDDLEWARE_AFTER, $callback);
$resp = $this->get('/login', ['Donkey' => 'cat']);
$resp->assertSee('cat456');
$resp->assertStatus(443);
}
protected function usingThemeFolder(callable $callback)
{
// Create a folder and configure a theme