webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-01-03 23:42:28 +03:00
Code Activity

Search: Prevented negated terms filling in UI inputs

Browse Source 
Added test to cover.
This commit is contained in:
Dan Brown
2024-10-03 19:38:07 +01:00
parent cd84d08157
commit 966ff91386
5 changed files with 28 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/Entity/EntitySearchTest.php
View File

@@ -577,6 +577,14 @@ class EntitySearchTest extends TestCase
$this->withHtml($resp)->assertFieldHasValue('extras', '{updated_by:dan} {created_by:dan} -"dog" -[a=b] -{viewed_by_me}');
}
public function test_negated_searches_dont_show_in_inputs()
{
$resp = $this->asEditor()->get('/search?term=' . urlencode('-{created_by:me} -[a=b] -"dog"'));
$this->withHtml($resp)->assertElementNotExists('input[name="tags[]"][value="a=b"]');
$this->withHtml($resp)->assertElementNotExists('input[name="exact[]"][value="dog"]');
$this->withHtml($resp)->assertElementNotExists('input[name="filters[created_by]"][value="me"][checked="checked"]');
}
public function test_searches_with_user_filters_using_me_adds_them_into_advanced_search_form()
{
$resp = $this->asEditor()->get('/search?term=' . urlencode('test {updated_by:me} {created_by:me}'));