webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-30 04:23:11 +03:00
Code Activity

Updated shelf-list view to enforce view permissions for child books

Browse Source 
- Aligned shelf-homepage behaviour to match
- Updated testing to cover.

For #2111
This commit is contained in:
Dan Brown
2020-05-12 22:21:45 +01:00
parent d3ec38bee3
commit 9666c8c0f7
4 changed files with 24 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/Entity/BookShelfTest.php
View File

@ -56,6 +56,25 @@ class BookShelfTest extends TestCase
$resp->assertElementContains('a', 'New Shelf');
}
public function test_book_not_visible_in_shelf_list_view_if_user_cant_view_shelf()
{
config()->set([
'app.views.bookshelves' => 'list',
]);
$shelf = Bookshelf::query()->first();
$book = $shelf->books()->first();
$resp = $this->asEditor()->get('/shelves');
$resp->assertSee($book->name);
$resp->assertSee($book->getUrl());
$this->setEntityRestrictions($book, []);
$resp = $this->asEditor()->get('/shelves');
$resp->assertDontSee($book->name);
$resp->assertDontSee($book->getUrl());
}
public function test_shelves_create()
{
$booksToInclude = Book::take(2)->get();