webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-01-03 23:42:28 +03:00
Code Activity

ZIP Imports: Fleshed out continue page, Added testing

Browse Source
This commit is contained in:
Dan Brown
2024-11-03 17:28:18 +00:00
parent c6109c7087
commit 8f6f81948e
6 changed files with 206 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

140
tests/Exports/ZipImportTest.php
View File

@@ -2,6 +2,8 @@
namespace Tests\Exports;
use BookStack\Activity\ActivityType;
use BookStack\Exports\Import;
use Illuminate\Http\UploadedFile;
use Illuminate\Testing\TestResponse;
use Tests\TestCase;
@@ -35,6 +37,25 @@ class ZipImportTest extends TestCase
$resp->assertSeeText('Select ZIP file to upload');
}
public function test_import_page_pending_import_visibility_limited()
{
$user = $this->users->viewer();
$admin = $this->users->admin();
$userImport = Import::factory()->create(['name' => 'MySuperUserImport', 'created_by' => $user->id]);
$adminImport = Import::factory()->create(['name' => 'MySuperAdminImport', 'created_by' => $admin->id]);
$this->permissions->grantUserRolePermissions($user, ['content-import']);
$resp = $this->actingAs($user)->get('/import');
$resp->assertSeeText('MySuperUserImport');
$resp->assertDontSeeText('MySuperAdminImport');
$this->permissions->grantUserRolePermissions($user, ['settings-manage']);
$resp = $this->actingAs($user)->get('/import');
$resp->assertSeeText('MySuperUserImport');
$resp->assertSeeText('MySuperAdminImport');
}
public function test_zip_read_errors_are_shown_on_validation()
{
$invalidUpload = $this->files->uploadedImage('image.zip');
@@ -105,6 +126,125 @@ class ZipImportTest extends TestCase
$resp->assertSeeText('[book.pages.1.tags.0.value]: The value must be a string.');
}
public function test_import_upload_success()
{
$admin = $this->users->admin();
$this->actingAs($admin);
$resp = $this->runImportFromFile($this->zipUploadFromData([
'book' => [
'name' => 'My great book name',
'chapters' => [
[
'name' => 'my chapter',
'pages' => [
[
'name' => 'my chapter page',
]
]
]
],
'pages' => [
[
'name' => 'My page',
]
],
],
]));
$this->assertDatabaseHas('imports', [
'name' => 'My great book name',
'book_count' => 1,
'chapter_count' => 1,
'page_count' => 2,
'created_by' => $admin->id,
]);
/** @var Import $import */
$import = Import::query()->latest()->first();
$resp->assertRedirect("/import/{$import->id}");
$this->assertFileExists(storage_path($import->path));
$this->assertActivityExists(ActivityType::IMPORT_CREATE);
}
public function test_import_show_page()
{
$import = Import::factory()->create(['name' => 'MySuperAdminImport']);
$resp = $this->asAdmin()->get("/import/{$import->id}");
$resp->assertOk();
$resp->assertSee('MySuperAdminImport');
}
public function test_import_show_page_access_limited()
{
$user = $this->users->viewer();
$admin = $this->users->admin();
$userImport = Import::factory()->create(['name' => 'MySuperUserImport', 'created_by' => $user->id]);
$adminImport = Import::factory()->create(['name' => 'MySuperAdminImport', 'created_by' => $admin->id]);
$this->actingAs($user);
$this->get("/import/{$userImport->id}")->assertRedirect('/');
$this->get("/import/{$adminImport->id}")->assertRedirect('/');
$this->permissions->grantUserRolePermissions($user, ['content-import']);
$this->get("/import/{$userImport->id}")->assertOk();
$this->get("/import/{$adminImport->id}")->assertStatus(404);
$this->permissions->grantUserRolePermissions($user, ['settings-manage']);
$this->get("/import/{$userImport->id}")->assertOk();
$this->get("/import/{$adminImport->id}")->assertOk();
}
public function test_import_delete()
{
$this->asAdmin();
$this->runImportFromFile($this->zipUploadFromData([
'book' => [
'name' => 'My great book name'
],
]));
/** @var Import $import */
$import = Import::query()->latest()->first();
$this->assertDatabaseHas('imports', [
'id' => $import->id,
'name' => 'My great book name'
]);
$this->assertFileExists(storage_path($import->path));
$resp = $this->delete("/import/{$import->id}");
$resp->assertRedirect('/import');
$this->assertActivityExists(ActivityType::IMPORT_DELETE);
$this->assertDatabaseMissing('imports', [
'id' => $import->id,
]);
$this->assertFileDoesNotExist(storage_path($import->path));
}
public function test_import_delete_access_limited()
{
$user = $this->users->viewer();
$admin = $this->users->admin();
$userImport = Import::factory()->create(['name' => 'MySuperUserImport', 'created_by' => $user->id]);
$adminImport = Import::factory()->create(['name' => 'MySuperAdminImport', 'created_by' => $admin->id]);
$this->actingAs($user);
$this->delete("/import/{$userImport->id}")->assertRedirect('/');
$this->delete("/import/{$adminImport->id}")->assertRedirect('/');
$this->permissions->grantUserRolePermissions($user, ['content-import']);
$this->delete("/import/{$userImport->id}")->assertRedirect('/import');
$this->delete("/import/{$adminImport->id}")->assertStatus(404);
$this->permissions->grantUserRolePermissions($user, ['settings-manage']);
$this->delete("/import/{$adminImport->id}")->assertRedirect('/import');
}
protected function runImportFromFile(UploadedFile $file): TestResponse
{
return $this->call('POST', '/import', [], [], ['file' => $file]);