webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-28 17:02:04 +03:00
Code Activity

Locales: More use of locale objects, Addressed failing tests

Browse Source
This commit is contained in:
Dan Brown
2023-09-17 16:20:21 +01:00
parent ac9a65945f
commit 8994c1b9d9
17 changed files with 92 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/LanguageTest.php
View File

@ -3,6 +3,7 @@
namespace Tests;
use BookStack\Activity\ActivityType;
use BookStack\Translation\LocaleManager;
class LanguageTest extends TestCase
{
@ -17,12 +18,12 @@ class LanguageTest extends TestCase
$this->langs = array_diff(scandir(lang_path('')), ['..', '.']);
}
public function test_locales_config_key_set_properly()
public function test_locales_list_set_properly()
{
$configLocales = config('app.locales');
sort($configLocales);
$appLocales = $this->app->make(LocaleManager::class)->getAllAppLocales();
sort($appLocales);
sort($this->langs);
$this->assertEquals(implode(':', $configLocales), implode(':', $this->langs), 'app.locales configuration variable does not match those found in lang files');
$this->assertEquals(implode(':', $this->langs), implode(':', $appLocales), 'app.locales configuration variable does not match those found in lang files');
}
// Not part of standard phpunit test runs since we sometimes expect non-added langs.
@ -75,14 +76,13 @@ class LanguageTest extends TestCase
}
}
public function test_rtl_config_set_if_lang_is_rtl()
public function test_views_use_rtl_if_rtl_language_is_set()
{
$this->asEditor();
// TODO - Alter
$this->assertFalse(config('app.rtl'), 'App RTL config should be false by default');
$this->asEditor()->withHtml($this->get('/'))->assertElementExists('html[dir="ltr"]');
setting()->putUser($this->users->editor(), 'language', 'ar');
$this->get('/');
$this->assertTrue(config('app.rtl'), 'App RTL config should have been set to true by middleware');
$this->withHtml($this->get('/'))->assertElementExists('html[dir="rtl"]');
}
public function test_unknown_lang_does_not_break_app()