webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-28 17:02:04 +03:00
Code Activity

Reviewed adding IP recording to activity & audit log

Browse Source 
Review of #2936

- Added testing to cover
- Added APP_PROXIES to .env.example.complete with details.
- Renamed migration to better align the name and to set the migration
  date to fit with production deploy order.
- Removed index from IP column in migration since an index does not yet
  provide any value.
- Updated table header text label.
- Prevented IP recording when in demo mode.
This commit is contained in:
Dan Brown
2021-09-26 17:18:12 +01:00
parent 8972f7b212
commit 887a79f130
6 changed files with 62 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
database/migrations/2021_08_21_044614_add_column_ip_into_activities.php → database/migrations/2021_09_26_044614_add_activities_ip_column.php
View File

@ -4,7 +4,7 @@ use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;
class AddColumnIpIntoActivities extends Migration
class AddActivitiesIpColumn extends Migration
{
/**
* Run the migrations.
@ -15,8 +15,6 @@ class AddColumnIpIntoActivities extends Migration
{
Schema::table('activities', function (Blueprint $table) {
$table->string('ip', 45)->after('user_id');
$table->index(['ip'], 'user_ip_idx');
});
}
@ -28,7 +26,6 @@ class AddColumnIpIntoActivities extends Migration
public function down()
{
Schema::table('activities', function (Blueprint $table) {
$table->dropIndex('user_ip_idx');
$table->dropColumn('ip');
});
}