webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-28 17:02:04 +03:00
Code Activity

Updated not-found image path handling to have better ux

Browse Source 
Added test to cover.
Started refactoring some of the app error handling in
the process of this.

Fixes #2696
This commit is contained in:
Dan Brown
2021-05-08 18:49:58 +01:00
parent 04c1d0e071
commit 7be7d7d1e7
7 changed files with 58 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/Exceptions/Handler.php
View File

@ -68,19 +68,6 @@ class Handler extends ExceptionHandler
return redirect($e->redirectLocation);
}
// Handle pretty exceptions which will show a friendly application-fitting page
// Which will include the basic message to point the user roughly to the cause.
if ($this->isExceptionType($e, PrettyException::class) && !config('app.debug')) {
$message = $this->getOriginalMessage($e);
$code = ($e->getCode() === 0) ? 500 : $e->getCode();
return response()->view('errors/' . $code, ['message' => $message], $code);
}
// Handle 404 errors with a loaded session to enable showing user-specific information
if ($this->isExceptionType($e, NotFoundHttpException::class)) {
return \Route::respondWithRoute('fallback');
}
return parent::render($request, $e);
}