webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-30 04:23:11 +03:00
Code Activity

Users: Changed name validation to min:1 instead of 2

Browse Source 
Would cause scenarios where users could be created with 1 char, but then
fail to update due to validation differences.
Added test to cover.
For #5263
This commit is contained in:
Dan Brown
2024-10-15 11:07:41 +01:00
parent 4dc75bad05
commit 6f1c54d018
3 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Users/Controllers/UserApiController.php
View File

@ -37,7 +37,7 @@ class UserApiController extends ApiController
{
return [
'create' => [
'name' => ['required', 'string', 'min:2', 'max:100'],
'name' => ['required', 'string', 'min:1', 'max:100'],
'email' => [
'required', 'string', 'email', 'min:2', new Unique('users', 'email'),
],
@ -49,7 +49,7 @@ class UserApiController extends ApiController
'send_invite' => ['boolean'],
],
'update' => [
'name' => ['string', 'min:2', 'max:100'],
'name' => ['string', 'min:1', 'max:100'],
'email' => [
'string',
'email',

2
app/Users/Controllers/UserController.php
View File

@ -144,7 +144,7 @@ class UserController extends Controller
$this->checkPermission('users-manage');
$validated = $this->validate($request, [
'name' => ['min:2', 'max:100'],
'name' => ['min:1', 'max:100'],
'email' => ['min:2', 'email', 'unique:users,email,' . $id],
'password' => ['required_with:password_confirm', Password::default()],
'password-confirm' => ['same:password', 'required_with:password'],