webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-28 17:02:04 +03:00
Code Activity

Added webhook call http exception handling

Browse Source 
Will now catch and log errors on events such as http timeouts.
For #3122
This commit is contained in:
Dan Brown
2022-01-03 18:37:05 +00:00
parent fe54c7f27a
commit 6e18620a0a
2 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/Actions/WebhookCallTest.php
View File

@ -60,6 +60,18 @@ class WebhookCallTest extends TestCase
$this->assertTrue($logger->hasError('Webhook call to endpoint https://wh.example.com failed with status 500'));
}
public function test_webhook_call_exception_is_caught_and_logged()
{
Http::shouldReceive('asJson')->andThrow(new \Exception('Failed to perform request'));
$logger = $this->withTestLogger();
$this->newWebhook(['active' => true, 'endpoint' => 'https://wh.example.com'], ['all']);
$this->runEvent(ActivityType::ROLE_CREATE);
$this->assertTrue($logger->hasError('Webhook call to endpoint https://wh.example.com failed with error "Failed to perform request"'));
}
public function test_webhook_call_data_format()
{
Http::fake([