webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-08-09 10:22:51 +03:00
Code Activity

Improved export base64 encoding of images

Browse Source 
Now will use set storage mechanism to find image files.
Fixes #786

Added test to cover
This commit is contained in:
Dan Brown
2018-04-22 12:23:43 +01:00
parent 6aeb1387aa
commit 67e0c3d2a5
3 changed files with 85 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/ImageTest.php
View File

@@ -106,6 +106,29 @@ class ImageTest extends TestCase
}
}
public function test_secure_images_included_in_exports()
{
config()->set('filesystems.default', 'local_secure');
$this->asEditor();
$galleryFile = $this->getTestImage('my-secure-test-upload');
$page = Page::first();
$expectedPath = storage_path('uploads/images/gallery/' . Date('Y-m-M') . '/my-secure-test-upload');
$upload = $this->call('POST', '/images/gallery/upload', ['uploaded_to' => $page->id], [], ['file' => $galleryFile], []);
$imageUrl = json_decode($upload->getContent(), true)['url'];
$page->html .= "<img src=\"{$imageUrl}\">";
$page->save();
$upload->assertStatus(200);
$encodedImageContent = base64_encode(file_get_contents($expectedPath));
$export = $this->get($page->getUrl('/export/html'));
$this->assertTrue(str_contains($export->getContent(), $encodedImageContent), 'Uploaded image in export content');
if (file_exists($expectedPath)) {
unlink($expectedPath);
}
}
public function test_system_images_remain_public()
{
config()->set('filesystems.default', 'local_secure');