webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-28 17:02:04 +03:00
Code Activity

Fixed incorrect pluralisation for de_informal

Browse Source 
Updated language system to only use initial part of locale for
translation pluralisation to better match the hard-coded logic of the
built-in MessageSelector. Extends and overrides Laravel's default for
this system.

Added test to cover.
Related to #3976.
This commit is contained in:
Dan Brown
2023-01-16 16:54:53 +00:00
parent 5393465ea7
commit 6070d804f8
3 changed files with 63 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/LanguageTest.php
View File

@ -4,7 +4,7 @@ namespace Tests;
class LanguageTest extends TestCase
{
protected $langs;
protected array $langs;
/**
* LanguageTest constructor.
@ -81,4 +81,16 @@ class LanguageTest extends TestCase
$this->get('/');
$this->assertTrue(config('app.rtl'), 'App RTL config should have been set to true by middleware');
}
public function test_pluralisation_for_non_standard_locales()
{
$text = trans_choice('entities.x_pages', 1, [], 'de_informal');
$this->assertEquals('1 Seite', $text);
$text = trans_choice('entities.x_pages', 2, [], 'de_informal');
$this->assertEquals('2 Seiten', $text);
$text = trans_choice('entities.x_pages', 0, [], 'de_informal');
$this->assertEquals('0 Seiten', $text);
}
}