mirror of
https://github.com/BookStackApp/BookStack.git
synced 2025-07-28 17:02:04 +03:00
Layout: Improved sidebar sizing, and dropdown consideration
- Updated tri-layout sidebars to have less padding and to avoid cutting off content when in single-sidebar mode. - Updated dropdown handling to consider the parent scroll container when deciding to drop upwards, to help prevent cut-off.
This commit is contained in:
@ -1,4 +1,4 @@
|
||||
import {onSelect} from '../services/dom.ts';
|
||||
import {findClosestScrollContainer, onSelect} from '../services/dom.ts';
|
||||
import {KeyboardNavigationHandler} from '../services/keyboard-navigation.ts';
|
||||
import {Component} from './component';
|
||||
|
||||
@ -33,7 +33,8 @@ export class Dropdown extends Component {
|
||||
const menuOriginalRect = this.menu.getBoundingClientRect();
|
||||
let heightOffset = 0;
|
||||
const toggleHeight = this.toggle.getBoundingClientRect().height;
|
||||
const dropUpwards = menuOriginalRect.bottom > window.innerHeight;
|
||||
const containerBounds = findClosestScrollContainer(this.menu).getBoundingClientRect();
|
||||
const dropUpwards = menuOriginalRect.bottom > containerBounds.bottom;
|
||||
const containerRect = this.container.getBoundingClientRect();
|
||||
|
||||
// If enabled, Move to body to prevent being trapped within scrollable sections
|
||||
|
@ -256,4 +256,22 @@ export function findTargetNodeAndOffset(parentNode: HTMLElement, offset: number)
|
||||
export function hashElement(element: HTMLElement): string {
|
||||
const normalisedElemText = (element.textContent || '').replace(/\s{2,}/g, '');
|
||||
return cyrb53(normalisedElemText);
|
||||
}
|
||||
|
||||
/**
|
||||
* Find the closest scroll container parent for the given element
|
||||
* otherwise will default to the body element.
|
||||
*/
|
||||
export function findClosestScrollContainer(start: HTMLElement): HTMLElement {
|
||||
let el: HTMLElement|null = start;
|
||||
do {
|
||||
const computed = window.getComputedStyle(el);
|
||||
if (computed.overflowY === 'scroll') {
|
||||
return el;
|
||||
}
|
||||
|
||||
el = el.parentElement;
|
||||
} while (el);
|
||||
|
||||
return document.body;
|
||||
}
|
Reference in New Issue
Block a user