webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-01-03 23:42:28 +03:00
Code Activity

Registration: Reviewed added simple honeypot, added testing

Browse Source 
Also cleaned up old RegistrationController syntax.
Review of #4970
This commit is contained in:
Dan Brown
2024-05-04 13:59:41 +01:00
parent 0d2a268be0
commit 5c28bcf865
3 changed files with 26 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/Access/Controllers/RegisterController.php
View File

@@ -15,24 +15,13 @@ use Illuminate\Validation\Rules\Password;
class RegisterController extends Controller
{
protected SocialDriverManager $socialDriverManager;
protected RegistrationService $registrationService;
protected LoginService $loginService;
/**
* Create a new controller instance.
*/
public function __construct(
SocialDriverManager $socialDriverManager,
RegistrationService $registrationService,
LoginService $loginService
protected SocialDriverManager $socialDriverManager,
protected RegistrationService $registrationService,
protected LoginService $loginService
) {
$this->middleware('guest');
$this->middleware('guard:standard');
$this->socialDriverManager = $socialDriverManager;
$this->registrationService = $registrationService;
$this->loginService = $loginService;
}
/**
@@ -87,7 +76,8 @@ class RegisterController extends Controller
'name' => ['required', 'min:2', 'max:100'],
'email' => ['required', 'email', 'max:255', 'unique:users'],
'password' => ['required', Password::default()],
'username' => ['prohibited'], // this is a honeypot for bots that must not be filled in
// Basic honey for bots that must not be filled in
'username' => ['prohibited'],
]);
}
}