webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-08-09 10:22:51 +03:00
Code Activity

Attachment API: Fixed error when name not provided in update

Browse Source 
Fixes #5353
This commit is contained in:
Dan Brown
2024-12-09 11:32:15 +00:00
parent 7e6f6af463
commit 55d074f1a5
2 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/Uploads/AttachmentService.php
View File

@@ -116,16 +116,18 @@ class AttachmentService
*/
public function updateFile(Attachment $attachment, array $requestData): Attachment
{
$attachment->name = $requestData['name'];
$link = trim($requestData['link'] ?? '');
if (isset($requestData['name'])) {
$attachment->name = $requestData['name'];
}
$link = trim($requestData['link'] ?? '');
if (!empty($link)) {
if (!$attachment->external) {
$this->deleteFileInStorage($attachment);
$attachment->external = true;
$attachment->extension = '';
}
$attachment->path = $requestData['link'];
$attachment->path = $link;
}
$attachment->save();