webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-30 04:23:11 +03:00
Code Activity

Started new permission-caching/querying model

Browse Source
This commit is contained in:
Dan Brown
2022-12-22 15:09:17 +00:00
parent 2d9d2bba80
commit 39acbeac68
6 changed files with 98 additions and 268 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/Helpers/PermissionsProvider.php
View File

@ -34,8 +34,6 @@ class PermissionsProvider
*/
public function removeUserRolePermissions(User $user, array $permissions): void
{
$permissionBuilder = app()->make(JointPermissionBuilder::class);
foreach ($permissions as $permissionName) {
/** @var RolePermission $permission */
$permission = RolePermission::query()
@ -49,7 +47,6 @@ class PermissionsProvider
/** @var Role $role */
foreach ($roles as $role) {
$role->detachPermission($permission);
$permissionBuilder->rebuildForRole($role);
}
$user->clearPermissionCache();

1
tests/PublicActionTest.php
View File

@ -89,7 +89,6 @@ class PublicActionTest extends TestCase
foreach (RolePermission::all() as $perm) {
$publicRole->attachPermission($perm);
}
$this->app->make(JointPermissionBuilder::class)->rebuildForRole($publicRole);
user()->clearPermissionCache();
$chapter = $this->entities->chapter();