webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-06-13 00:41:59 +03:00
Code Activity

Page JS: Improved block jumping and highlighting

Browse Source 
- Updated anchor scroll change to open up details blocks if the target
  exists within.
- Updated highlighting and animation implementation to fix hardly visible highlighting.
- Removed old, now unused, handing of CM instances in details blocks.

Related to #4637.
This commit is contained in:
Dan Brown
2023-11-01 18:49:47 +00:00
parent 324e403ae5
commit 38ac3c959b
2 changed files with 22 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
resources/js/components/page-display.js
View File

@ -37,7 +37,6 @@ export class PageDisplay extends Component {
window.importVersioned('code').then(Code => Code.highlight());
this.setupNavHighlighting();
this.setupDetailsCodeBlockRefresh();
// Check the hash on load
if (window.location.hash) {
@ -87,14 +86,4 @@ export class PageDisplay extends Component {
}
}
setupDetailsCodeBlockRefresh() {
const onToggle = event => {
const codeMirrors = [...event.target.querySelectorAll('.CodeMirror')];
codeMirrors.forEach(cm => cm.CodeMirror && cm.CodeMirror.refresh());
};
const details = [...this.container.querySelectorAll('details')];
details.forEach(detail => detail.addEventListener('toggle', onToggle));
}
}