webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-31 15:24:31 +03:00
Code Activity

Ensured uploaded system images remain public

Browse Source 
Also added tests to cover local_secure image storage.

Fixes #725
This commit is contained in:
Dan Brown
2018-03-25 12:41:52 +01:00
parent f1586be516
commit 23f90ed6b4
5 changed files with 59 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/Services/AttachmentService.php
View File

@ -14,10 +14,6 @@ class AttachmentService extends UploadService
*/
protected function getStorage()
{
if ($this->storageInstance !== null) {
return $this->storageInstance;
}
$storageType = config('filesystems.default');
// Override default location if set to local public to ensure not visible.
@ -25,9 +21,7 @@ class AttachmentService extends UploadService
$storageType = 'local_secure';
}
$this->storageInstance = $this->fileSystem->disk($storageType);
return $this->storageInstance;
return $this->fileSystem->disk($storageType);
}
/**